Skip to content

Conversation

szymonrybczak
Copy link
Collaborator

@szymonrybczak szymonrybczak commented Nov 6, 2023

Summary:

According to Node docs, fs.rmdir(path, { recursive: true }) will be deprecated and right now fs.rm is a right choice.

Test Plan:

  1. Clone the repository and do all the required steps from the Contributing guide
  2. Run this command:
node /path/to/react-native-cli/packages/cli/build/bin.js clean

Works in the same way as before.

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

@github-actions github-actions bot added the infra Internal work not facing public APIs label Nov 6, 2023
@thymikee
Copy link
Member

thymikee commented Nov 6, 2023

Do we want to use force option as well?

@szymonrybczak szymonrybczak merged commit 24f4e39 into main Nov 6, 2023
@szymonrybczak szymonrybczak deleted the chore/replace-fs-rmdir-with-fs-rm branch November 6, 2023 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

infra Internal work not facing public APIs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants