fix: replacing package name in Kotlin template #2209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szymonrybczak
force-pushed
the
fix/replacing-package-name-rn-073
branch
from
3666bc6
to
053028a
Compare
|
Also I updated the fixtures, to align with current state of Java/Kotlin template. |
cortinico
approved these changes
Dec 27, 2023
thymikee
reviewed
Jan 8, 2024
packages/cli/src/commands/init/__tests__/__snapshots__/editTemplate.test.ts.snap
Show resolved
Hide resolved
szymonrybczak
force-pushed
the
fix/replacing-package-name-rn-073
branch
2 times, most recently
from
e294d79
to
9d20955
Compare
szymonrybczak
force-pushed
the
fix/replacing-package-name-rn-073
branch
2 times, most recently
from
929df71
to
fd61479
Compare
thymikee
reviewed
Jan 9, 2024
thymikee
reviewed
Jan 9, 2024
szymonrybczak
force-pushed
the
fix/replacing-package-name-rn-073
branch
3 times, most recently
from
60c3ea6
to
1127cce
Compare
szymonrybczak
force-pushed
the
fix/replacing-package-name-rn-073
branch
from
1127cce
to
9d1a1c0
Compare
thymikee
reviewed
Jan 9, 2024
packages/cli/src/commands/init/__tests__/__snapshots__/editTemplate.test.ts.snap
Outdated
Show resolved
Hide resolved
thymikee
reviewed
Jan 10, 2024
szymonrybczak
force-pushed
the
fix/replacing-package-name-rn-073
branch
from
c90052f
to
847f5d6
Compare
thymikee
approved these changes
Jan 10, 2024
thymikee
pushed a commit
that referenced
this pull request
Jan 10, 2024
* fix: replacing name in Kotlin template * fix(test): update snapshots * test: update `contextLines` * fix: use `utf-8` when reading files
2 tasks
thymikee
added a commit
that referenced
this pull request
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Closes #2205
CLI when replacing placeholders in init command is looking for return
"HelloWorld", but during template's conversation from Java to Kotlin the function was simplified, and scripting for editing template doesn't see this anymore. So right now we need to look for=.Test Plan:
Checklist