Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherry pick "fix: replacing package name in Kotlin template (#2209)" #2255

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

thymikee
Copy link
Member

@thymikee thymikee commented Jan 10, 2024

Summary:

port #2209 to 12.x

Test Plan:

Checklist

  • Documentation is up to date to reflect these changes.
  • Follows commit message convention described in CONTRIBUTING.md

* fix: replacing name in Kotlin template

* fix(test): update snapshots

* test: update `contextLines`

* fix: use `utf-8` when reading files
Copy link
Collaborator

@szymonrybczak szymonrybczak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Initialised an app, and it is building correctly with custom package name.

CleanShot 2024-01-10 at 19 10 48@2x

@thymikee thymikee merged commit 90453db into 12.x Jan 12, 2024
10 checks passed
@thymikee thymikee deleted the 12-kotlin branch January 12, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants