Skip to content

Conversation

dulmandakh
Copy link
Contributor

@dulmandakh dulmandakh commented Nov 1, 2020

build-essential installs dpkg-dev in addition to compiler tools, which depends on perl and other tools used to build Debian packages. g++ install gcc, and this change will install gcc, g++, make tools. We would save 70MB.

@gengjiawen
Copy link
Member

In this change, I would like stay the same. build-essential is the most common way install c/c++ toolchains.
Second, it contains make, gcc, g++, in usual cases, you want all of them.

@dulmandakh
Copy link
Contributor Author

@gengjiawen please see PR description

@dulmandakh dulmandakh requested a review from gengjiawen November 1, 2020 11:06
@dulmandakh dulmandakh changed the title g++ compiler tools Nov 1, 2020
Copy link
Member

@gengjiawen gengjiawen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI passed.

@dulmandakh dulmandakh merged commit 94cf737 into react-native-community:master Nov 1, 2020
@dulmandakh dulmandakh deleted the gcc branch November 1, 2020 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants