Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[useImageDimensions] types refactored #148

Merged
merged 1 commit into from
Apr 17, 2020
Merged

[useImageDimensions] types refactored #148

merged 1 commit into from
Apr 17, 2020

Conversation

Greg-Bush
Copy link
Contributor

@Greg-Bush Greg-Bush commented Apr 17, 2020 •
edited
Loading

Summary

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌
Web ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)
  • I've created a snack to demonstrate the changes: LINK HERE

@Greg-Bush Greg-Bush closed this Apr 17, 2020
@Greg-Bush Greg-Bush reopened this Apr 17, 2020
@LinusU LinusU added patch Increment the patch version when merged release Create a release when this pr is merged labels Apr 17, 2020
@LinusU
Copy link
Member

LinusU commented Apr 17, 2020

Thanks

@LinusU LinusU merged commit 605a783 into react-native-community:master Apr 17, 2020
@pvinis
Copy link
Member

pvinis commented Apr 17, 2020

🚀 PR was released in v2.5.1 🚀

@pvinis pvinis added the released This issue/pull request has been released. label Apr 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LinusU LinusU LinusU approved these changes

Assignees
No one assigned
Labels
patch Increment the patch version when merged release Create a release when this pr is merged released This issue/pull request has been released.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Greg-Bush @LinusU @pvinis