Support IPv4/6 on iOS #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matt-oakes
reviewed
Jul 18, 2019
|
Sure @matt-oakes no rush, let me know if you need anything from my end |
react-native-community-bot
pushed a commit
that referenced
this pull request
Jul 19, 2019
## [4.1.2](v4.1.1...v4.1.2) (2019-07-19) ### Bug Fixes * **iOS:** Ensure IPv6 networks work correctly ([#146](#146) by [@enahum](https://github.com/enahum)) ([f4e3378](f4e3378))
|
🎉 This PR is included in version 4.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Summary
At Mattermost we received a lot of reports about Internet Reachability not working on LTE networks that assign IPv6 addresses, the current implementation uses a hostname based to test for reachability and the hostname "apple.com" does not have IPv6 addresses causing the check to fail.
With this PR we implemented the Internet connectivity test exposed in this example
it uses a different mechanism.
☝️ for some reason it seems that is does not work great with IPv6 as the hostname does not have IPv6 addresses assigned
With the changes made we are now using this:
Test Plan
The changes in code only affect iOS and there should not be any changes in behavior other than detecting internet connectivity on IPv6 networks