Skip to content

[cli-v2] Fix pod dependency error #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

JunichiSugiura
Copy link
Contributor

Summary

This PR fixes error when react-native-cli installs pod dependencies. react-native@0.60.0 seems that it still depends on React-fishhook so I added it to the Podfile. https://github.com/facebook/react-native/blob/v0.60.0/template/ios/Podfile#L9.

Test Plan

This command successfully initializes a new project.

npx react-native init MyApp --template=https://github.com/LukeSugiura/react-native-template-typescript#master-cli-v2

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

npx react-native init MyApp --template=react-native-template-typescript@next

Screen Shot 2019-07-10 at 12 30 24

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I mentioned this change in CHANGELOG.md
  • I updated the typed files (TS and Flow)
  • I added a sample use of the API in the example project (example/App.js)

@emin93
Copy link
Member

emin93 commented Jul 10, 2019

Shouldn't this happen with the default RN template as well? (This template Podfile is the same as in the default template.)

@emin93
Copy link
Member

emin93 commented Jul 10, 2019

I just saw they updated the Podfile in the RN repo, can you update it to match and try again: https://github.com/facebook/react-native/blob/master/template/ios/Podfile

If it works, please commit the changes to the PR and I'll merge it 🙂.

/edit
Forget what I wrote above, I just realized, the master branch is not matching with the 0.60.0 tag 😄.

Thanks for the PR, going to merge it now and release a new version.

@emin93 emin93 merged commit 51b9a2e into react-native-community:master-cli-v2 Jul 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants