Objective-C version for 0.77.1?

[tibbe]

Is there an Objective-C version for 0.77.1? We're not ready to migrate to Swift yet as several of the packages we depend on (e.g. Firebase) are not yet ready or have at least not provided any instructions how to install/setup in a Swift setting.

[cortinico]

cc @cipolleschi

[cipolleschi]

The code is exactly the same of 0.76 (.h, .mm), with a single extra difference in the .mm file:

#import "AppDelegate.h"

#import <React/RCTBundleURLProvider.h>
+ #import <ReactAppDependencyProvider/RCTAppDependencyProvider.h>

 - (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
  self.moduleName = @"HelloWorld";
  // You can add your custom initial props in the dictionary below.
  // They will be passed down to the ViewController used by React Native.
  self.initialProps = @{};
+ self.dependencyProvider = [RCTAppDependencyProvider new];

  return [super application:application didFinishLaunchingWithOptions:launchOptions];
}

[dkornilove]

The code is exactly the same of 0.76 (.h, .mm), with a single extra difference in the .mm file:

#import "AppDelegate.h"

#import <React/RCTBundleURLProvider.h>

• #import <ReactAppDependencyProvider/RCTAppDependencyProvider.h>

• (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
  {
  self.moduleName = @"HelloWorld";
  // You can add your custom initial props in the dictionary below.
  // They will be passed down to the ViewController used by React Native.
  self.initialProps = @{};

• self.dependencyProvider = [RCTAppDependencyProvider new];

  return [super application:application didFinishLaunchingWithOptions:launchOptions];
  }

can you please provide patch snippet for AppDelegate.m, not AppDelegate.mm ?

here is my source code

#import "AppDelegate.h"

#import <React/RCTBridge.h>
#import <React/RCTBundleURLProvider.h>
#import <React/RCTRootView.h>

#import <PushKit/PushKit.h>
#import "RNCallKeep.h"
#import "RNNotifications.h"
#import "RNVoipPushNotificationManager.h"
#import "RNSplashScreen.h"
#import "ApiManager.h"
#import "AudioManager.h"
#import "RNVIClientModule.h"
#import <Firebase.h>

@import Intents;

#ifdef FB_SONARKIT_ENABLED
#import <FlipperKit/FlipperClient.h>
#import <FlipperKitLayoutPlugin/FlipperKitLayoutPlugin.h>
#import <FlipperKitUserDefaultsPlugin/FKUserDefaultsPlugin.h>
#import <FlipperKitNetworkPlugin/FlipperKitNetworkPlugin.h>
#import <SKIOSNetworkPlugin/SKIOSNetworkAdapter.h>
#import <FlipperKitReactPlugin/FlipperKitReactPlugin.h>

static void InitializeFlipper(UIApplication *application) {
  FlipperClient *client = [FlipperClient sharedClient];
  SKDescriptorMapper *layoutDescriptorMapper = [[SKDescriptorMapper alloc] initWithDefaults];
  [client addPlugin:[[FlipperKitLayoutPlugin alloc] initWithRootNode:application withDescriptorMapper:layoutDescriptorMapper]];
  [client addPlugin:[[FKUserDefaultsPlugin alloc] initWithSuiteName:nil]];
  [client addPlugin:[FlipperKitReactPlugin new]];
  [client addPlugin:[[FlipperKitNetworkPlugin alloc] initWithNetworkAdapter:[SKIOSNetworkAdapter new]]];
  [client start];
}
#endif

@implementation AppDelegate

- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
#ifdef FB_SONARKIT_ENABLED
  InitializeFlipper(application);
#endif
  //init firebase
  [FIRApp configure];

  RCTBridge *bridge = [[RCTBridge alloc] initWithDelegate:self launchOptions:launchOptions];
  
  // ===== (THIS IS OPTIONAL BUT RECOMMENDED) =====
  // --- register VoipPushNotification here ASAP rather than in JS. Doing this from the JS side may be too slow for some use cases
  // --- see: https://github.com/react-native-webrtc/react-native-voip-push-notification/issues/59#issuecomment-691685841
  [RNVoipPushNotificationManager voipRegistration];
  // ===== (THIS IS OPTIONAL BUT RECOMMENDED) =====
  
  [RNNotifications startMonitorNotifications];
  
  [RNCallKeep setup:@{
    @"appName": @"appname",
    @"imageName": @"icon",
    @"supportsVideo": @NO,
    @"maximumCallGroups": @1,
    @"maximumCallsPerCallGroup": @1,
    @"handleType": @"generic",
    @"includesCallsInRecents": @YES
  }];
  
  RCTRootView *rootView = [[RCTRootView alloc] initWithBridge:bridge
                                                   moduleName:@"srost"
                                            initialProperties:nil];

  if (@available(iOS 13.0, *)) {
      rootView.backgroundColor = [UIColor systemBackgroundColor];
  } else {
      rootView.backgroundColor = [UIColor whiteColor];
  }

  self.window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds];
  UIViewController *rootViewController = [UIViewController new];
  rootViewController.view = rootView;
  self.window.rootViewController = rootViewController;
  [self.window makeKeyAndVisible];
  

  
  // for show push alert when app in foreground
  [UNUserNotificationCenter currentNotificationCenter].delegate = self;

  [AudioManager requestRecordPermission];

  [RNSplashScreen show];
  
  return YES;
}
...

i can not figure out how to properly make the changes in .m file and expiriencing this error again and again

[cipolleschi]

@dkornilove your AppDelegate is extremely old....

For example, Flipper is deprecated... you should remove it completely.

The patch below should conceptually be it. You should double check the types and the APIs and it could be that you have to import some other header. But that how you should update it.

#import "AppDelegate.h"
+ #import <ReactAppDependencyProvider/RCTAppDependencyProvider.h>
-#import <React/RCTBridge.h>
#import <React/RCTBundleURLProvider.h>
#import <React/RCTRootView.h>

#import <PushKit/PushKit.h>
#import "RNCallKeep.h"
#import "RNNotifications.h"
#import "RNVoipPushNotificationManager.h"
#import "RNSplashScreen.h"
#import "ApiManager.h"
#import "AudioManager.h"
#import "RNVIClientModule.h"
#import <Firebase.h>

@import Intents;

-#ifdef FB_SONARKIT_ENABLED
-#import <FlipperKit/FlipperClient.h>
-#import <FlipperKitLayoutPlugin/FlipperKitLayoutPlugin.h>
-#import <FlipperKitUserDefaultsPlugin/FKUserDefaultsPlugin.h>
-#import <FlipperKitNetworkPlugin/FlipperKitNetworkPlugin.h>
-#import <SKIOSNetworkPlugin/SKIOSNetworkAdapter.h>
-#import <FlipperKitReactPlugin/FlipperKitReactPlugin.h>

-static void InitializeFlipper(UIApplication *application) {
- FlipperClient *client = [FlipperClient sharedClient];
-  SKDescriptorMapper *layoutDescriptorMapper = [[SKDescriptorMapper alloc] initWithDefaults];
-  [client addPlugin:[[FlipperKitLayoutPlugin alloc] initWithRootNode:application withDescriptorMapper:layoutDescriptorMapper]];
-  [client addPlugin:[[FKUserDefaultsPlugin alloc] initWithSuiteName:nil]];
-  [client addPlugin:[FlipperKitReactPlugin new]];
-  [client addPlugin:[[FlipperKitNetworkPlugin alloc] initWithNetworkAdapter:[SKIOSNetworkAdapter new]]];
-  [client start];
-}
-#endif

@implementation AppDelegate

- (BOOL)application:(UIApplication *)application didFinishLaunchingWithOptions:(NSDictionary *)launchOptions
{
-#ifdef FB_SONARKIT_ENABLED
-  InitializeFlipper(application);
-#endif
  //init firebase
  [FIRApp configure];

-  RCTBridge *bridge = [[RCTBridge alloc] initWithDelegate:self launchOptions:launchOptions];
  
  // ===== (THIS IS OPTIONAL BUT RECOMMENDED) =====
  // --- register VoipPushNotification here ASAP rather than in JS. Doing this from the JS side may be too slow for some use cases
  // --- see: https://github.com/react-native-webrtc/react-native-voip-push-notification/issues/59#issuecomment-691685841
  [RNVoipPushNotificationManager voipRegistration];
  // ===== (THIS IS OPTIONAL BUT RECOMMENDED) =====
  
+ self.moduleName = @"srost";
+ self.dependencyProvider = [RCTAppDependencyProvider new];

+ [super.application: application didFinishLaunchingWithOptions: launchOptions];

  [RNNotifications startMonitorNotifications];
  
  [RNCallKeep setup:@{
    @"appName": @"appname",
    @"imageName": @"icon",
    @"supportsVideo": @NO,
    @"maximumCallGroups": @1,
    @"maximumCallsPerCallGroup": @1,
    @"handleType": @"generic",
    @"includesCallsInRecents": @YES
  }];
  
-  RCTRootView *rootView = [[RCTRootView alloc] initWithBridge:bridge
-                                                   moduleName:@"srost"
-                                            initialProperties:nil];

-  if (@available(iOS 13.0, *)) {
-      rootView.backgroundColor = [UIColor systemBackgroundColor];
-  } else {
-      rootView.backgroundColor = [UIColor whiteColor];
-  }

-  self.window = [[UIWindow alloc] initWithFrame:[UIScreen mainScreen].bounds];
-  UIViewController *rootViewController = [UIViewController new];
-  rootViewController.view = rootView;
-  self.window.rootViewController = rootViewController;
-  [self.window makeKeyAndVisible];
  

  
  // for show push alert when app in foreground
  [UNUserNotificationCenter currentNotificationCenter].delegate = self;

  [AudioManager requestRecordPermission];

  [RNSplashScreen show];

  return YES;
}

+- (NSURL *)sourceURLForBridge:(RCTBridge *)bridge
+{
+  return [self bundleURL];
+}

+- (NSURL *)bundleURL
+{
+#if DEBUG
+    [RCTBundleURLProvider.sharedSettings jsBundleURLForBundleRoot: @"index"];
+#else
+    [NSBundle.mainBundle urlForResource: @"main" withExtension: @"jsbundle"];
+#endif
+}
+
+- (void)customizeRootView:(RCTRootView)rootView
+{
+  rootView.backgroundColor = [UIColor systemBackgroundColor];
+}
...

[dkornilove]

@cipolleschi thanks for the reply! with your help i figured out to migrate to .mm file