Skip to content

Added screenshots #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 16, 2018
Merged

Added screenshots #83

merged 5 commits into from
May 16, 2018

Conversation

Noitidart
Copy link
Collaborator

@Noitidart Noitidart commented May 16, 2018

This adds screenshots and two small bug fixes.

  • screenshots to readme - will not show until merged to master as its using "https://github.com/aakashns/" as image paths
  • fixed multi choice, when nothing was selected it was giving [ undefined ]
  • no spacing in showProgress when horizontal style

Noitidart added 2 commits May 16, 2018 00:55
* fixed multi choice, when nothing was selected it was giving [ undefined ]
* no spacing in showProgress when horizontal style
@Noitidart Noitidart requested a review from vonovak May 16, 2018 18:39
@vonovak vonovak merged commit e9933c3 into react-native-dialogs:master May 16, 2018
@Noitidart
Copy link
Collaborator Author

Thank you @vonovak !

@Noitidart
Copy link
Collaborator Author

Woohoo the images for the code examples are showing! (i guessed on those paths haha) Check it out please @aakashns :)

@aakashns
Copy link
Collaborator

Looks great! Thanks for the amazing work @Noitidart!

Please also add a contributors/maintainers sections listing yourself and @vonovak as contributors.

@Noitidart
Copy link
Collaborator Author

Thanks @aakashns! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants