Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input is not exported in TypeScript definitions #947

Closed
Mukeyii opened this issue Feb 26, 2018 · 8 comments
Closed

Input is not exported in TypeScript definitions #947

Mukeyii opened this issue Feb 26, 2018 · 8 comments
Labels
🐛 Bug 🗂 Types
Milestone
Beta 3 Release

Comments

@Mukeyii
Copy link

Mukeyii commented Feb 26, 2018

Description

1. Explain what you did

I've updated from 0.19 to 1.0.0-beta to change the style of my Searchbar (works). Had to replace FormInput with Input to avoid the Invariant-Violation-Error.

2. What you expected to happen

I can still import FormInput, FormLabel etc. from the beta-version (index.d.ts), but 'Input' can't be found.

import {Text, Button, Input, Icon, Card} from 'react-native-elements';
@iRoachie
Copy link
Collaborator

What version of the beta are you currently on?

@Mukeyii
Copy link
Author

Mukeyii commented Feb 26, 2018

"react-native-elements": "^1.0.0-beta2",

@iRoachie
Copy link
Collaborator

You're correct! Forgot to update the definitions.

@iRoachie iRoachie changed the title Cannot resolve symbol 'Input' Input is not exported in TypeScript definitions Feb 26, 2018
@iRoachie
Copy link
Collaborator

For anyone that wants to take this up, they can check the FormInput definitions for an example on how to add definitions for a component.

@msevestre
Copy link
Contributor

Yeah I'll take a look

msevestre pushed a commit to msevestre/react-native-elements that referenced this issue Feb 28, 2018
@ospsuite
Fixes react-native-elements#947 Input is not exported in TypeScript d…
695a54a 
…efinitions
iRoachie pushed a commit that referenced this issue Feb 28, 2018
@msevestre @iRoachie
Export Input in TypeScript definitions (#953)
29f30d4 
* Fixes #947 Input is not exported in TypeScript definitions

* Use react-native TextInputProperties and match type description to docs description

* Add missing methods for Input component
@iRoachie
Copy link
Collaborator

iRoachie commented Mar 1, 2018

Added in react-native-training/react-native-elements@29f30d4, should be apart of the 1.0.0-beta3 release

@iRoachie iRoachie added this to the Beta 3 Release milestone Mar 5, 2018
iRoachie pushed a commit that referenced this issue Mar 7, 2018
@msevestre @iRoachie
Export Input in TypeScript definitions (#953)
ff3734f 
* Fixes #947 Input is not exported in TypeScript definitions

* Use react-native TextInputProperties and match type description to docs description

* Add missing methods for Input component
iRoachie pushed a commit that referenced this issue Mar 8, 2018
@msevestre @iRoachie
Export Input in TypeScript definitions (#953)
1cb627a 
* Fixes #947 Input is not exported in TypeScript definitions

* Use react-native TextInputProperties and match type description to docs description

* Add missing methods for Input component
iRoachie pushed a commit that referenced this issue Mar 8, 2018
@msevestre @iRoachie
Export Input in TypeScript definitions (#953)
be9e189 
* Fixes #947 Input is not exported in TypeScript definitions

* Use react-native TextInputProperties and match type description to docs description

* Add missing methods for Input component
iRoachie pushed a commit that referenced this issue Mar 8, 2018
@msevestre @iRoachie
Export Input in TypeScript definitions (#953)
422c8a3 
* Fixes #947 Input is not exported in TypeScript definitions

* Use react-native TextInputProperties and match type description to docs description

* Add missing methods for Input component
@lifeiscontent
Copy link

@iRoachie when will the release be posted?

@iRoachie
Copy link
Collaborator

iRoachie commented Mar 10, 2018 •
edited

@lifeiscontent Sunday (tomorrow)

@Monte9 Monte9 closed this as completed in edf9bfb Mar 11, 2018
timotew pushed a commit to timotew/react-native-elements that referenced this issue Mar 23, 2018
@xavier-villelegier @timotew
v1.0.0-beta3 (react-native-elements#915)
47558ce 
* Updated readme with RNW todo + opencollective

* Rename back `text` to `title`

* Fix tests and Princing card

* Fix searchbar methods next (react-native-elements#916)

* Updated readme with RNW todo + opencollective

* Rename back `text` to `title`

* Fix tests and Princing card

* Rename `clearText` into `clear`

* Apply default props on iOS SearchBar

* Update SearchBar wrapper with methods

* Update docs and ts

* Fix android onClear naming in PropTypes

* Remove useless condition

* Use default props

* Update snapshots

* Add more tests

* Update cancel methods doc

* fix(header): Alignment on android now consistent with iOS (react-native-elements#944)

* chore(package): Bump version

* Adds header centerComponent alignment (react-native-elements#946)

* Header title align

* Update snapshots and formatting

* Rename centerComponentStyles to centerComponentStyle

* Add ts defs for new props

* Add docs for new header props

* Remove redundant android statusbar height

* docs: Allow viewing `next` docs in version switch

* docs(header): Add left aligned center component example

* [Button] Auto import LinearGradient if Expo (react-native-elements#943)

* Warning only for non-expo user

* Auto import LinearGradient on Expo

* Show warning if non-expo user

* Update example

* Update snapshot

* Use `width: '100%'` for Input (react-native-elements#954)

* Export Input in TypeScript definitions (react-native-elements#953)

* Fixes react-native-elements#947 Input is not exported in TypeScript definitions

* Use react-native TextInputProperties and match type description to docs description

* Add missing methods for Input component

* Fix styled-component for Input and Button (react-native-elements#956)

* Fix styled-component for Input

* Fix styled-component for Button

* docs(website): Changed master to next for current changes

* Make optional `selectedIndexes` property optional

* disabled button update

* style(typings): Prettier

* feat(typings): Adds disabled props to button

Ref react-native-elements#982

* docs(website): Add disabled props for Button

* Move Imgur images to GitHub  (react-native-elements#974)

* Replace imgur images for button, badge, button_group

* Replace card, checkbox images

* Replace form images

* Replace imgaes for getting started, icons, lists, pricing, rating, searchbar

* Replace input images

* Replace lists, social icons, text images

* Replace images in readme

* feat(website): Add react native training logo to footer

Closes react-native-elements#975

* Allow title for Card to be a React Component (react-native-elements#918) (react-native-elements#968)

* docs(website): Allow card title to be react native component

* Add support for different icon type in Avatar component react-native-elements#942 (react-native-elements#980)

* Add support for different icon type in Avatar component react-native-elements#942

* Revert previous git hook react-native-elements#942

* docs(website): Better syntax colouring for code blocks (react-native-elements#983)
xavier-villelegier pushed a commit that referenced this issue Apr 1, 2018
@martinezguillaume @xavier-villelegier
ListItem v1 (Android & iOS) (#945)
92e5e83 
* Updated readme with RNW todo + opencollective

* Rename back `text` to `title`

* Fix tests and Princing card

* Fix searchbar methods next (#916)

* Updated readme with RNW todo + opencollective

* Rename back `text` to `title`

* Fix tests and Princing card

* Rename `clearText` into `clear`

* Apply default props on iOS SearchBar

* Update SearchBar wrapper with methods

* Update docs and ts

* Fix android onClear naming in PropTypes

* Remove useless condition

* Use default props

* Update snapshots

* Add more tests

* Update cancel methods doc

* fix(header): Alignment on android now consistent with iOS (#944)

* chore(package): Bump version

* Refractor ListItem

* Add buttonGroup (+ fix checkbox)

* Remove useless style

* Fix inputStyle props of TextInput

* Fix flex TextInput

* Fix flex layout

* Fix TextInput height

* Updated readme with RNW todo + opencollective

* Rename back `text` to `title`

* Fix tests and Princing card

* Fix searchbar methods next (#916)

* Updated readme with RNW todo + opencollective

* Rename back `text` to `title`

* Fix tests and Princing card

* Rename `clearText` into `clear`

* Apply default props on iOS SearchBar

* Update SearchBar wrapper with methods

* Update docs and ts

* Fix android onClear naming in PropTypes

* Remove useless condition

* Use default props

* Update snapshots

* Add more tests

* Update cancel methods doc

* fix(header): Alignment on android now consistent with iOS (#944)

* chore(package): Bump version

* Adds header centerComponent alignment (#946)

* Header title align

* Update snapshots and formatting

* Rename centerComponentStyles to centerComponentStyle

* Add ts defs for new props

* Add docs for new header props

* Remove redundant android statusbar height

* docs: Allow viewing `next` docs in version switch

* docs(header): Add left aligned center component example

* [Button] Auto import LinearGradient if Expo (#943)

* Warning only for non-expo user

* Auto import LinearGradient on Expo

* Show warning if non-expo user

* Update example

* Update snapshot

* Use `width: '100%'` for Input (#954)

* Export Input in TypeScript definitions (#953)

* Fixes #947 Input is not exported in TypeScript definitions

* Use react-native TextInputProperties and match type description to docs description

* Add missing methods for Input component

* Fix styled-component for Input and Button (#956)

* Fix styled-component for Input

* Fix styled-component for Button

* Update docs

* Add checkmarkColor & disclosureColor

* Add topDivider & bottomDivider

* Add platform specific Divider

* Add inputContainerStyle to Input

* Add Divider to List

* Refractor Divider

* Refractor ListItem

* Add buttonGroup (+ fix checkbox)

* Remove useless style

* Fix inputStyle props of TextInput

* Fix flex TextInput

* Fix flex layout

* Fix TextInput height

* Update docs

* Add checkmarkColor & disclosureColor

* Add topDivider & bottomDivider

* Add platform specific Divider

* Add inputContainerStyle to Input

* Add Divider to List

* Refractor Divider

* Use hairlineWidth for Divider

* Rebase from next

* Rebase from next

* docs(v2): Correct prop on Button to be text

* Add text default width if buttonStyle has a width (#995)

* Refractor ListItem

* Add buttonGroup (+ fix checkbox)

* Remove useless style

* Fix inputStyle props of TextInput

* Fix flex TextInput

* Fix flex layout

* Fix TextInput height

* Update docs

* Add checkmarkColor & disclosureColor

* Add topDivider & bottomDivider

* Add platform specific Divider

* Add inputContainerStyle to Input

* Add Divider to List

* Refractor Divider

* Add buttonGroup (+ fix checkbox)

* Fix flex TextInput

* Add checkmarkColor & disclosureColor

* Add topDivider & bottomDivider

* Use hairlineWidth for Divider

* Rebase from next

* Fix rebase conflict

* Fix conflict

* Fix conflict

* Add scaleProps & ViewComponent

* Add react-native-touchable-scale

* Add gradient/scale example

* Rename props

* Update docs

* Add precise contentContainerStyle desc

* Add rightIcon & rightAvatar

* Add rightSubtitle props

* Add styling to texts

* Add border to List

* Use RNE primary color (for upcoming theming feature)

* Fix proptypes

* Fix checkmark

* Update List doc

* Fix typo

* Explain `Input` styles

* Update input style docs

* Update tests and dependencies

* Add back inputContainerStyle

* Removed List component + update ListItem docs

* Fix listitem id in website sidebar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🐛 Bug 🗂 Types
Projects
None yet
Milestone
Beta 3 Release
Development

No branches or pull requests
4 participants
@lifeiscontent @msevestre @iRoachie @Mukeyii