ListItem v1 (Android & iOS) #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updated readme with RNW todo + opencollective * Rename back `text` to `title` * Fix tests and Princing card * Rename `clearText` into `clear` * Apply default props on iOS SearchBar * Update SearchBar wrapper with methods * Update docs and ts * Fix android onClear naming in PropTypes * Remove useless condition * Use default props * Update snapshots * Add more tests * Update cancel methods doc
3 tasks
* Updated readme with RNW todo + opencollective * Rename back `text` to `title` * Fix tests and Princing card * Rename `clearText` into `clear` * Apply default props on iOS SearchBar * Update SearchBar wrapper with methods * Update docs and ts * Fix android onClear naming in PropTypes * Remove useless condition * Use default props * Update snapshots * Add more tests * Update cancel methods doc
* Header title align * Update snapshots and formatting * Rename centerComponentStyles to centerComponentStyle * Add ts defs for new props * Add docs for new header props * Remove redundant android statusbar height * docs: Allow viewing `next` docs in version switch * docs(header): Add left aligned center component example
* Warning only for non-expo user * Auto import LinearGradient on Expo * Show warning if non-expo user * Update example * Update snapshot
* Fixes #947 Input is not exported in TypeScript definitions * Use react-native TextInputProperties and match type description to docs description * Add missing methods for Input component
* Fix styled-component for Input * Fix styled-component for Button
|
Example app for the last commit (b5e7dee): |
# Conflicts: # src/input/Input.js # src/searchbar/SearchBar-android.js
xavier-villelegier
approved these changes
Apr 1, 2018
|
here we goo.. 🤞 |
Codecov Report
@@ Coverage Diff @@
## next #945 +/- ##
=========================================
- Coverage 56.38% 55.9% -0.49%
=========================================
Files 34 33 -1
Lines 603 610 +7
Branches 108 110 +2
=========================================
+ Hits 340 341 +1
- Misses 211 215 +4
- Partials 52 54 +2
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.