Fixes #947 Input is not exported in TypeScript definitions #953

msevestre · 2018-02-28T17:34:53Z

No description provided.

…efinitions

msevestre

There are a few methods in the Input component that are not part of the properties and are NEVER used a far as I can tell

blur
focus
clear

Also the TypeScript definitions file contains definition for types that are not exported anymore such as FormInput. Should they be removed as well?

msevestre · 2018-02-28T17:35:37Z

src/index.d.ts

+  /**
+    * Left icon
+    */
+  leftIcon?: JSX.Element;


I am not sure about that this property. Let me know if this should be changed

codecov · 2018-02-28T17:39:22Z

Codecov Report

Merging #953 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #953   +/-   ##
=======================================
  Coverage   55.88%   55.88%           
=======================================
  Files          32       32           
  Lines         578      578           
  Branches      114      114           
=======================================
  Hits          323      323           
  Misses        201      201           
  Partials       54       54

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aac4b2a...57e2498. Read the comment docs.

iRoachie

InputProps should extend from TextInputProperties from react native https://react-native-training.github.io/react-native-elements/docs/input.html#input-props

…cs description

msevestre · 2018-02-28T19:54:48Z

@iRoachie Ok thanks for the info. I also adjusted the type descriptions to match the doc descriptions

iRoachie

One more thing, we need to implement these methods.

https://github.com/react-native-training/react-native-elements/blob/master/src/input/Input.js#L25-L37

msevestre · 2018-02-28T20:21:13Z

@iRoachie Sorry man. Hopefully good to go now

iRoachie · 2018-02-28T22:34:45Z

Thanks again @msevestre

* Fixes #947 Input is not exported in TypeScript definitions * Use react-native TextInputProperties and match type description to docs description * Add missing methods for Input component

* Updated readme with RNW todo + opencollective * Rename back `text` to `title` * Fix tests and Princing card * Fix searchbar methods next (#916) * Updated readme with RNW todo + opencollective * Rename back `text` to `title` * Fix tests and Princing card * Rename `clearText` into `clear` * Apply default props on iOS SearchBar * Update SearchBar wrapper with methods * Update docs and ts * Fix android onClear naming in PropTypes * Remove useless condition * Use default props * Update snapshots * Add more tests * Update cancel methods doc * fix(header): Alignment on android now consistent with iOS (#944) * chore(package): Bump version * Adds header centerComponent alignment (#946) * Header title align * Update snapshots and formatting * Rename centerComponentStyles to centerComponentStyle * Add ts defs for new props * Add docs for new header props * Remove redundant android statusbar height * docs: Allow viewing `next` docs in version switch * docs(header): Add left aligned center component example * [Button] Auto import LinearGradient if Expo (#943) * Warning only for non-expo user * Auto import LinearGradient on Expo * Show warning if non-expo user * Update example * Update snapshot * Use `width: '100%'` for Input (#954) * Export Input in TypeScript definitions (#953) * Fixes #947 Input is not exported in TypeScript definitions * Use react-native TextInputProperties and match type description to docs description * Add missing methods for Input component * Fix styled-component for Input and Button (#956) * Fix styled-component for Input * Fix styled-component for Button * docs(website): Changed master to next for current changes * Make optional `selectedIndexes` property optional * disabled button update * style(typings): Prettier * feat(typings): Adds disabled props to button Ref #982 * docs(website): Add disabled props for Button * Move Imgur images to GitHub (#974) * Replace imgur images for button, badge, button_group * Replace card, checkbox images * Replace form images * Replace imgaes for getting started, icons, lists, pricing, rating, searchbar * Replace input images * Replace lists, social icons, text images * Replace images in readme * feat(website): Add react native training logo to footer Closes #975 * Allow title for Card to be a React Component (#918) (#968) * docs(website): Allow card title to be react native component * Add support for different icon type in Avatar component #942 (#980) * Add support for different icon type in Avatar component #942 * Revert previous git hook #942 * docs(website): Better syntax colouring for code blocks (#983)

* Updated readme with RNW todo + opencollective * Rename back `text` to `title` * Fix tests and Princing card * Fix searchbar methods next (react-native-elements#916) * Updated readme with RNW todo + opencollective * Rename back `text` to `title` * Fix tests and Princing card * Rename `clearText` into `clear` * Apply default props on iOS SearchBar * Update SearchBar wrapper with methods * Update docs and ts * Fix android onClear naming in PropTypes * Remove useless condition * Use default props * Update snapshots * Add more tests * Update cancel methods doc * fix(header): Alignment on android now consistent with iOS (react-native-elements#944) * chore(package): Bump version * Adds header centerComponent alignment (react-native-elements#946) * Header title align * Update snapshots and formatting * Rename centerComponentStyles to centerComponentStyle * Add ts defs for new props * Add docs for new header props * Remove redundant android statusbar height * docs: Allow viewing `next` docs in version switch * docs(header): Add left aligned center component example * [Button] Auto import LinearGradient if Expo (react-native-elements#943) * Warning only for non-expo user * Auto import LinearGradient on Expo * Show warning if non-expo user * Update example * Update snapshot * Use `width: '100%'` for Input (react-native-elements#954) * Export Input in TypeScript definitions (react-native-elements#953) * Fixes react-native-elements#947 Input is not exported in TypeScript definitions * Use react-native TextInputProperties and match type description to docs description * Add missing methods for Input component * Fix styled-component for Input and Button (react-native-elements#956) * Fix styled-component for Input * Fix styled-component for Button * docs(website): Changed master to next for current changes * Make optional `selectedIndexes` property optional * disabled button update * style(typings): Prettier * feat(typings): Adds disabled props to button Ref react-native-elements#982 * docs(website): Add disabled props for Button * Move Imgur images to GitHub (react-native-elements#974) * Replace imgur images for button, badge, button_group * Replace card, checkbox images * Replace form images * Replace imgaes for getting started, icons, lists, pricing, rating, searchbar * Replace input images * Replace lists, social icons, text images * Replace images in readme * feat(website): Add react native training logo to footer Closes react-native-elements#975 * Allow title for Card to be a React Component (react-native-elements#918) (react-native-elements#968) * docs(website): Allow card title to be react native component * Add support for different icon type in Avatar component react-native-elements#942 (react-native-elements#980) * Add support for different icon type in Avatar component react-native-elements#942 * Revert previous git hook react-native-elements#942 * docs(website): Better syntax colouring for code blocks (react-native-elements#983)

* Updated readme with RNW todo + opencollective * Rename back `text` to `title` * Fix tests and Princing card * Fix searchbar methods next (#916) * Updated readme with RNW todo + opencollective * Rename back `text` to `title` * Fix tests and Princing card * Rename `clearText` into `clear` * Apply default props on iOS SearchBar * Update SearchBar wrapper with methods * Update docs and ts * Fix android onClear naming in PropTypes * Remove useless condition * Use default props * Update snapshots * Add more tests * Update cancel methods doc * fix(header): Alignment on android now consistent with iOS (#944) * chore(package): Bump version * Refractor ListItem * Add buttonGroup (+ fix checkbox) * Remove useless style * Fix inputStyle props of TextInput * Fix flex TextInput * Fix flex layout * Fix TextInput height * Updated readme with RNW todo + opencollective * Rename back `text` to `title` * Fix tests and Princing card * Fix searchbar methods next (#916) * Updated readme with RNW todo + opencollective * Rename back `text` to `title` * Fix tests and Princing card * Rename `clearText` into `clear` * Apply default props on iOS SearchBar * Update SearchBar wrapper with methods * Update docs and ts * Fix android onClear naming in PropTypes * Remove useless condition * Use default props * Update snapshots * Add more tests * Update cancel methods doc * fix(header): Alignment on android now consistent with iOS (#944) * chore(package): Bump version * Adds header centerComponent alignment (#946) * Header title align * Update snapshots and formatting * Rename centerComponentStyles to centerComponentStyle * Add ts defs for new props * Add docs for new header props * Remove redundant android statusbar height * docs: Allow viewing `next` docs in version switch * docs(header): Add left aligned center component example * [Button] Auto import LinearGradient if Expo (#943) * Warning only for non-expo user * Auto import LinearGradient on Expo * Show warning if non-expo user * Update example * Update snapshot * Use `width: '100%'` for Input (#954) * Export Input in TypeScript definitions (#953) * Fixes #947 Input is not exported in TypeScript definitions * Use react-native TextInputProperties and match type description to docs description * Add missing methods for Input component * Fix styled-component for Input and Button (#956) * Fix styled-component for Input * Fix styled-component for Button * Update docs * Add checkmarkColor & disclosureColor * Add topDivider & bottomDivider * Add platform specific Divider * Add inputContainerStyle to Input * Add Divider to List * Refractor Divider * Refractor ListItem * Add buttonGroup (+ fix checkbox) * Remove useless style * Fix inputStyle props of TextInput * Fix flex TextInput * Fix flex layout * Fix TextInput height * Update docs * Add checkmarkColor & disclosureColor * Add topDivider & bottomDivider * Add platform specific Divider * Add inputContainerStyle to Input * Add Divider to List * Refractor Divider * Use hairlineWidth for Divider * Rebase from next * Rebase from next * docs(v2): Correct prop on Button to be text * Add text default width if buttonStyle has a width (#995) * Refractor ListItem * Add buttonGroup (+ fix checkbox) * Remove useless style * Fix inputStyle props of TextInput * Fix flex TextInput * Fix flex layout * Fix TextInput height * Update docs * Add checkmarkColor & disclosureColor * Add topDivider & bottomDivider * Add platform specific Divider * Add inputContainerStyle to Input * Add Divider to List * Refractor Divider * Add buttonGroup (+ fix checkbox) * Fix flex TextInput * Add checkmarkColor & disclosureColor * Add topDivider & bottomDivider * Use hairlineWidth for Divider * Rebase from next * Fix rebase conflict * Fix conflict * Fix conflict * Add scaleProps & ViewComponent * Add react-native-touchable-scale * Add gradient/scale example * Rename props * Update docs * Add precise contentContainerStyle desc * Add rightIcon & rightAvatar * Add rightSubtitle props * Add styling to texts * Add border to List * Use RNE primary color (for upcoming theming feature) * Fix proptypes * Fix checkmark * Update List doc * Fix typo * Explain `Input` styles * Update input style docs * Update tests and dependencies * Add back inputContainerStyle * Removed List component + update ListItem docs * Fix listitem id in website sidebar

Fixes react-native-elements#947 Input is not exported in TypeScript d…

695a54a

…efinitions

msevestre commented Feb 28, 2018

View reviewed changes

xavier-villelegier requested a review from iRoachie February 28, 2018 17:47

xavier-villelegier added the 🗂 Types label Feb 28, 2018

iRoachie requested changes Feb 28, 2018

View reviewed changes

Use react-native TextInputProperties and match type description to do…

4c2d154

…cs description

iRoachie approved these changes Feb 28, 2018

View reviewed changes

iRoachie requested changes Feb 28, 2018

View reviewed changes

Add missing methods for Input component

57e2498

iRoachie approved these changes Feb 28, 2018

View reviewed changes

iRoachie changed the base branch from master to next February 28, 2018 22:15

iRoachie force-pushed the next branch from 88156eb to 5025bba Compare February 28, 2018 22:33

iRoachie merged commit 29f30d4 into react-native-elements:next Feb 28, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes #947 Input is not exported in TypeScript definitions #953

Fixes #947 Input is not exported in TypeScript definitions #953

msevestre commented Feb 28, 2018

msevestre left a comment

msevestre Feb 28, 2018

codecov bot commented Feb 28, 2018 •

edited

iRoachie left a comment

msevestre commented Feb 28, 2018

iRoachie left a comment

msevestre commented Feb 28, 2018

iRoachie commented Feb 28, 2018

Fixes #947 Input is not exported in TypeScript definitions #953

Fixes #947 Input is not exported in TypeScript definitions #953

Conversation

msevestre commented Feb 28, 2018

msevestre left a comment

Choose a reason for hiding this comment

msevestre Feb 28, 2018

Choose a reason for hiding this comment

codecov bot commented Feb 28, 2018 • edited

Codecov Report

iRoachie left a comment

Choose a reason for hiding this comment

msevestre commented Feb 28, 2018

iRoachie left a comment

Choose a reason for hiding this comment

msevestre commented Feb 28, 2018

iRoachie commented Feb 28, 2018

codecov bot commented Feb 28, 2018 •

edited