-
-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use width: '100%'
for Input
#954
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## next #954 +/- ##
=====================================
Coverage 55.2% 55.2%
=====================================
Files 33 33
Lines 605 605
Branches 112 112
=====================================
Hits 334 334
Misses 217 217
Partials 54 54
Continue to review full report at Codecov.
|
iRoachie
approved these changes
Feb 28, 2018
iRoachie
pushed a commit
that referenced
this pull request
Feb 28, 2018
iRoachie
pushed a commit
that referenced
this pull request
Mar 7, 2018
iRoachie
pushed a commit
that referenced
this pull request
Mar 8, 2018
iRoachie
pushed a commit
that referenced
this pull request
Mar 8, 2018
iRoachie
pushed a commit
that referenced
this pull request
Mar 8, 2018
Monte9
pushed a commit
that referenced
this pull request
Mar 11, 2018
* Updated readme with RNW todo + opencollective * Rename back `text` to `title` * Fix tests and Princing card * Fix searchbar methods next (#916) * Updated readme with RNW todo + opencollective * Rename back `text` to `title` * Fix tests and Princing card * Rename `clearText` into `clear` * Apply default props on iOS SearchBar * Update SearchBar wrapper with methods * Update docs and ts * Fix android onClear naming in PropTypes * Remove useless condition * Use default props * Update snapshots * Add more tests * Update cancel methods doc * fix(header): Alignment on android now consistent with iOS (#944) * chore(package): Bump version * Adds header centerComponent alignment (#946) * Header title align * Update snapshots and formatting * Rename centerComponentStyles to centerComponentStyle * Add ts defs for new props * Add docs for new header props * Remove redundant android statusbar height * docs: Allow viewing `next` docs in version switch * docs(header): Add left aligned center component example * [Button] Auto import LinearGradient if Expo (#943) * Warning only for non-expo user * Auto import LinearGradient on Expo * Show warning if non-expo user * Update example * Update snapshot * Use `width: '100%'` for Input (#954) * Export Input in TypeScript definitions (#953) * Fixes #947 Input is not exported in TypeScript definitions * Use react-native TextInputProperties and match type description to docs description * Add missing methods for Input component * Fix styled-component for Input and Button (#956) * Fix styled-component for Input * Fix styled-component for Button * docs(website): Changed master to next for current changes * Make optional `selectedIndexes` property optional * disabled button update * style(typings): Prettier * feat(typings): Adds disabled props to button Ref #982 * docs(website): Add disabled props for Button * Move Imgur images to GitHub (#974) * Replace imgur images for button, badge, button_group * Replace card, checkbox images * Replace form images * Replace imgaes for getting started, icons, lists, pricing, rating, searchbar * Replace input images * Replace lists, social icons, text images * Replace images in readme * feat(website): Add react native training logo to footer Closes #975 * Allow title for Card to be a React Component (#918) (#968) * docs(website): Allow card title to be react native component * Add support for different icon type in Avatar component #942 (#980) * Add support for different icon type in Avatar component #942 * Revert previous git hook #942 * docs(website): Better syntax colouring for code blocks (#983)
timotew
pushed a commit
to timotew/react-native-elements
that referenced
this pull request
Mar 23, 2018
* Updated readme with RNW todo + opencollective * Rename back `text` to `title` * Fix tests and Princing card * Fix searchbar methods next (react-native-elements#916) * Updated readme with RNW todo + opencollective * Rename back `text` to `title` * Fix tests and Princing card * Rename `clearText` into `clear` * Apply default props on iOS SearchBar * Update SearchBar wrapper with methods * Update docs and ts * Fix android onClear naming in PropTypes * Remove useless condition * Use default props * Update snapshots * Add more tests * Update cancel methods doc * fix(header): Alignment on android now consistent with iOS (react-native-elements#944) * chore(package): Bump version * Adds header centerComponent alignment (react-native-elements#946) * Header title align * Update snapshots and formatting * Rename centerComponentStyles to centerComponentStyle * Add ts defs for new props * Add docs for new header props * Remove redundant android statusbar height * docs: Allow viewing `next` docs in version switch * docs(header): Add left aligned center component example * [Button] Auto import LinearGradient if Expo (react-native-elements#943) * Warning only for non-expo user * Auto import LinearGradient on Expo * Show warning if non-expo user * Update example * Update snapshot * Use `width: '100%'` for Input (react-native-elements#954) * Export Input in TypeScript definitions (react-native-elements#953) * Fixes react-native-elements#947 Input is not exported in TypeScript definitions * Use react-native TextInputProperties and match type description to docs description * Add missing methods for Input component * Fix styled-component for Input and Button (react-native-elements#956) * Fix styled-component for Input * Fix styled-component for Button * docs(website): Changed master to next for current changes * Make optional `selectedIndexes` property optional * disabled button update * style(typings): Prettier * feat(typings): Adds disabled props to button Ref react-native-elements#982 * docs(website): Add disabled props for Button * Move Imgur images to GitHub (react-native-elements#974) * Replace imgur images for button, badge, button_group * Replace card, checkbox images * Replace form images * Replace imgaes for getting started, icons, lists, pricing, rating, searchbar * Replace input images * Replace lists, social icons, text images * Replace images in readme * feat(website): Add react native training logo to footer Closes react-native-elements#975 * Allow title for Card to be a React Component (react-native-elements#918) (react-native-elements#968) * docs(website): Allow card title to be react native component * Add support for different icon type in Avatar component react-native-elements#942 (react-native-elements#980) * Add support for different icon type in Avatar component react-native-elements#942 * Revert previous git hook react-native-elements#942 * docs(website): Better syntax colouring for code blocks (react-native-elements#983)
xavier-villelegier
pushed a commit
that referenced
this pull request
Apr 1, 2018
* Updated readme with RNW todo + opencollective * Rename back `text` to `title` * Fix tests and Princing card * Fix searchbar methods next (#916) * Updated readme with RNW todo + opencollective * Rename back `text` to `title` * Fix tests and Princing card * Rename `clearText` into `clear` * Apply default props on iOS SearchBar * Update SearchBar wrapper with methods * Update docs and ts * Fix android onClear naming in PropTypes * Remove useless condition * Use default props * Update snapshots * Add more tests * Update cancel methods doc * fix(header): Alignment on android now consistent with iOS (#944) * chore(package): Bump version * Refractor ListItem * Add buttonGroup (+ fix checkbox) * Remove useless style * Fix inputStyle props of TextInput * Fix flex TextInput * Fix flex layout * Fix TextInput height * Updated readme with RNW todo + opencollective * Rename back `text` to `title` * Fix tests and Princing card * Fix searchbar methods next (#916) * Updated readme with RNW todo + opencollective * Rename back `text` to `title` * Fix tests and Princing card * Rename `clearText` into `clear` * Apply default props on iOS SearchBar * Update SearchBar wrapper with methods * Update docs and ts * Fix android onClear naming in PropTypes * Remove useless condition * Use default props * Update snapshots * Add more tests * Update cancel methods doc * fix(header): Alignment on android now consistent with iOS (#944) * chore(package): Bump version * Adds header centerComponent alignment (#946) * Header title align * Update snapshots and formatting * Rename centerComponentStyles to centerComponentStyle * Add ts defs for new props * Add docs for new header props * Remove redundant android statusbar height * docs: Allow viewing `next` docs in version switch * docs(header): Add left aligned center component example * [Button] Auto import LinearGradient if Expo (#943) * Warning only for non-expo user * Auto import LinearGradient on Expo * Show warning if non-expo user * Update example * Update snapshot * Use `width: '100%'` for Input (#954) * Export Input in TypeScript definitions (#953) * Fixes #947 Input is not exported in TypeScript definitions * Use react-native TextInputProperties and match type description to docs description * Add missing methods for Input component * Fix styled-component for Input and Button (#956) * Fix styled-component for Input * Fix styled-component for Button * Update docs * Add checkmarkColor & disclosureColor * Add topDivider & bottomDivider * Add platform specific Divider * Add inputContainerStyle to Input * Add Divider to List * Refractor Divider * Refractor ListItem * Add buttonGroup (+ fix checkbox) * Remove useless style * Fix inputStyle props of TextInput * Fix flex TextInput * Fix flex layout * Fix TextInput height * Update docs * Add checkmarkColor & disclosureColor * Add topDivider & bottomDivider * Add platform specific Divider * Add inputContainerStyle to Input * Add Divider to List * Refractor Divider * Use hairlineWidth for Divider * Rebase from next * Rebase from next * docs(v2): Correct prop on Button to be text * Add text default width if buttonStyle has a width (#995) * Refractor ListItem * Add buttonGroup (+ fix checkbox) * Remove useless style * Fix inputStyle props of TextInput * Fix flex TextInput * Fix flex layout * Fix TextInput height * Update docs * Add checkmarkColor & disclosureColor * Add topDivider & bottomDivider * Add platform specific Divider * Add inputContainerStyle to Input * Add Divider to List * Refractor Divider * Add buttonGroup (+ fix checkbox) * Fix flex TextInput * Add checkmarkColor & disclosureColor * Add topDivider & bottomDivider * Use hairlineWidth for Divider * Rebase from next * Fix rebase conflict * Fix conflict * Fix conflict * Add scaleProps & ViewComponent * Add react-native-touchable-scale * Add gradient/scale example * Rename props * Update docs * Add precise contentContainerStyle desc * Add rightIcon & rightAvatar * Add rightSubtitle props * Add styling to texts * Add border to List * Use RNE primary color (for upcoming theming feature) * Fix proptypes * Fix checkmark * Update List doc * Fix typo * Explain `Input` styles * Update input style docs * Update tests and dependencies * Add back inputContainerStyle * Removed List component + update ListItem docs * Fix listitem id in website sidebar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #861 and prevents #952