Migrated segmentedControlIos from RN core to community version #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cpojer
approved these changes
Feb 22, 2019
There was a problem hiding this comment.
Sorry it took me a few days to review this. Thank you so much, this is looking good!
Next steps:
- Can you tell me your npm username?
- Can you publish this package on npm community and make sure it works when linked into React Native?
- Can you send a deprecation message for this component to the React Native repository?
Thank you!
|
My npm username is 'harisbaig100', i will publish this on npm after testing and will send deprecation message for this component. |
|
Awesome, I added you to I'd also like to send you an invite to our RN community Discord. Mind sending me an email to cpojer@fb.com? Thanks! |
|
Sure, i will send you an email, send me invitation at 'harisbaig100@gmail.com'. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.