Fix broken compilation in v1.1.0 #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Naturalclar
reviewed
Jan 21, 2020
Naturalclar
reviewed
Jan 21, 2020
Naturalclar
requested changes
Jan 21, 2020
There was a problem hiding this comment.
@nacho-carnicero Thanks for the PR! I've made some suggestions, could you take a look at it?
Co-Authored-By: Jesse Katsumata <niconico.clarinet@gmail.com>
nacho-carnicero
commented
Jan 21, 2020
There was a problem hiding this comment.
@Naturalclar I made the requested changes, should be good for merging 👍
Naturalclar
approved these changes
Jan 22, 2020
Merged
|
Released v1.1.1 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Following the issue in #43 I am adding this PR in order to fix the compilation. Basically I:
RNCSegmentedControlManager.*files were not added)Reactimports in the project from#import "RCTLibrary.h"to#import <React/RCTLibrary.h>NOTE: I only added a link to the manually linking instructions, but this should be done in a better way (for instance by doing a
pod installor something like this). I don't know very much how installed libraries can be added to the Podfile of the root project when being installed so I did not add that change here, but this would be a nice enhancement to this PR.Test Plan
Basically I just tested that by making those changes my app which would not compile before now compiles.