Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest version of react gives PropTypes warning #1410

Closed
BrockWills opened this issue Apr 10, 2017 · 36 comments

Comments

Projects
None yet
@BrockWills
Copy link
Contributor

commented Apr 10, 2017

With React 15.5, importing PropTypes from React is deprecated in favour of importing from the new 'prop-types' package.

See this link: https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html

Thus, using react-toolbox with the latest version of react gives a deprecation warning in the console.

Will look into a PR for this.

@vldmr1986

This comment has been minimized.

Copy link

commented Apr 10, 2017

The same warnings:

  • in my local console:
    warning "react-toolbox@2.0.0-beta.6" has incorrect peer dependency "react@^0.14 || ~15.4.0".
    warning "react-toolbox@2.0.0-beta.6" has incorrect peer dependency "react-dom@^0.14.0 || ~15.4.0".
  • browser console:
    Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.
@flexzero

This comment has been minimized.

Copy link

commented Apr 11, 2017

+1

@BrockWills

This comment has been minimized.

Copy link
Contributor Author

commented Apr 12, 2017

#1413 Should hopefully solve this

@mytechnotalent

This comment has been minimized.

Copy link

commented Apr 16, 2017

Utilizing the FlipMove package causes the PropTypes deprecated warning even after following the best practice illustrated here: https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html

@sjain-mi9

This comment has been minimized.

Copy link

commented Apr 24, 2017

Even after importing PropTypes from prop-types, I'm receiving the same Warning.
"react-toolbox": "^2.0.0-beta.8"
"prop-types": "15.5.8"
"react": "^15.5.4"

2c434891b10ce64db58122a38b93bbbd4bbc1db44a1a767704 pimgpsh_fullsize_distr

@DORRITO

This comment has been minimized.

Copy link

commented Apr 27, 2017

Same here! Importing react-flip-move gives me the error, despite having the correct and updated proptypes import.

@mandelaloko

This comment has been minimized.

Copy link

commented May 2, 2017

Also with me:
captura de tela 2017-05-02 as 15 52 42

"dependencies": {
    "classnames": "^2.2.5",
    "firebase": "^3.7.5",
    "firebaseui": "^1.0.1",
    "immutability-helper": "^2.1.2",
    "lodash": "^4.17.4",
    "re-base": "^2.7.0",
    "react": "^15.5.4",
    "react-dom": "^15.5.4",
    "react-router-dom": "^4.1.1",
    "react-tag-input": "^4.7.1",
    "reactfire": "^1.0.0",
    "slugify": "^1.1.0"
  },

@BrunoQuaresma

This comment has been minimized.

Copy link

commented May 11, 2017

+1

1 similar comment
@Kliton

This comment has been minimized.

Copy link

commented May 12, 2017

+1

@raunofreiberg

This comment has been minimized.

Copy link

commented May 15, 2017

Getting the same error here.

@Omortis

This comment has been minimized.

Copy link

commented May 16, 2017

Same here. Note that I'm not using PropTypes directly anywhere in my code though it seems to be called out many times by imported modules.

react@15.5.4
prop-types@15.5.10

Looks like it's mostly bootstrap 0.30 doing the dirty work?

bootstrap-proptypes

@oshalygin

This comment has been minimized.

Copy link

commented May 18, 2017

Same issue, not using PropTypes from the react package anywhere in my code but its still throwing this warning.

EDIT: If anyone is still having my issue, make sure its not another package. A simple way is to pull up the dev tools and then look through the warning stacktrace by putting a breakpoint on the error and refreshing the page. Go up the callstack.

@nivek91

This comment has been minimized.

Copy link

commented May 18, 2017

+1

@JuliusPopoola

This comment has been minimized.

Copy link

commented May 20, 2017

+1

I have removed all references to PropTypes and the warning message is still showing

@steve-goodwin

This comment has been minimized.

Copy link

commented May 22, 2017

+1

3 similar comments
@devjaw

This comment has been minimized.

Copy link

commented May 23, 2017

+1

@SH-Stark

This comment has been minimized.

Copy link

commented May 23, 2017

+1

@BHouwens

This comment has been minimized.

Copy link

commented May 23, 2017

+1

@tobiasandersen

This comment has been minimized.

Copy link
Contributor

commented May 23, 2017

Seriously, please stop writing +1 comments. I'm sure the maintainers will fix this when they have the time and energy to do so. If you still feel like you have to +1, use the reaction feature provided by GitHub for that exact purpose.

Each time you write a new comment, a lot of people will get notifications about it (yes, I know that I'm doing the same here, sorry about that). And also, consider that the people maintaining this library is probably doing it on their free time, and that they might already be stressed/feel guilty about open issues and PRs (which they really shouldn't!).

@ttawan

This comment has been minimized.

Copy link

commented May 29, 2017

+1

@javivelasco

This comment has been minimized.

Copy link
Member

commented May 29, 2017

@tobiasandersen, your comment should be stated at the top of the README. You totally nailed it and indeed I'm working on this on my spare time. It is generating a lot of personal issues that I can't take anymore, and I feel like I can't deal with all. I can still work on the project but probably not as much as the community might require. This is open source, please contribute everybody and I promise I'll be checking on PRs and releasing new versions when I have time for it.

BTW, a new version was already released with support for React 15.5 so I'm closing.
Thank you

@kalm42

This comment has been minimized.

Copy link

commented May 30, 2017

+1

2 similar comments
@gouzaa

This comment has been minimized.

Copy link

commented May 31, 2017

+1

@hongduclam

This comment has been minimized.

Copy link

commented Jun 6, 2017

+1

@javivelasco

This comment has been minimized.

Copy link
Member

commented Jun 6, 2017

Such a pity you three can't be banned from using the project

@srajiv-xpio

This comment has been minimized.

Copy link

commented Jun 7, 2017

+1

2 similar comments
@ghost

This comment has been minimized.

Copy link

commented Jun 12, 2017

+1

@zzwar2009

This comment has been minimized.

Copy link

commented Jun 16, 2017

+1

@jaydevonline

This comment has been minimized.

Copy link

commented Jun 19, 2017

And above three also.

@ghost

This comment has been minimized.

Copy link

commented Jun 19, 2017

+1

@ghost

This comment has been minimized.

Copy link

commented Jun 19, 2017

@tobiasandersen plus 1 add information about how recently ppl have been having the issue

@tobiasandersen

This comment has been minimized.

Copy link
Contributor

commented Jun 20, 2017

@ericswenson15 What are you talking about? This issue is fixed in the latest release.

@javivelasco

This comment has been minimized.

Copy link
Member

commented Jun 20, 2017

@ericswenson15 this is solved. If you are getting this warning with the latest react-toolbox it is some other lib

@thekhenzie

This comment has been minimized.

Copy link

commented Oct 3, 2017

+1

@rubenmoya

This comment has been minimized.

Copy link
Collaborator

commented Oct 3, 2017

Not sure about that last +1, but if you're having the same problem, please open a new issue, since this one was closed months ago, thank you! :)

@chenop

This comment has been minimized.

Copy link

commented Oct 25, 2017

I was getting this error for a whlie , until I figure out that the following line also produce this error:
import * as React from "react";
Fixing to the following in all my files:
import React from "react";
Did the trick for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.