Latest version of react gives PropTypes warning

[BrockWills]

With React 15.5, importing PropTypes from React is deprecated in favour of importing from the new 'prop-types' package.

See this link: https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html

Thus, using react-toolbox with the latest version of react gives a deprecation warning in the console.

Will look into a PR for this.

[vldmr1986]

The same warnings:

• in my local console:
  warning "react-toolbox@2.0.0-beta.6" has incorrect peer dependency "react@^0.14 || ~15.4.0".
  warning "react-toolbox@2.0.0-beta.6" has incorrect peer dependency "react-dom@^0.14.0 || ~15.4.0".
• browser console:
  Warning: Accessing PropTypes via the main React package is deprecated. Use the prop-types package from npm instead.

[flexzero]

+1

[BrockWills]

#1413 Should hopefully solve this

[mytechnotalent]

Utilizing the FlipMove package causes the PropTypes deprecated warning even after following the best practice illustrated here: https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html

[sjain-mi9]

Even after importing PropTypes from prop-types, I'm receiving the same Warning.
"react-toolbox": "^2.0.0-beta.8"
"prop-types": "15.5.8"
"react": "^15.5.4"

[Lrigh1]

Same here! Importing react-flip-move gives me the error, despite having the correct and updated proptypes import.

[mandelaloko]

Also with me:

"dependencies": {
    "classnames": "^2.2.5",
    "firebase": "^3.7.5",
    "firebaseui": "^1.0.1",
    "immutability-helper": "^2.1.2",
    "lodash": "^4.17.4",
    "re-base": "^2.7.0",
    "react": "^15.5.4",
    "react-dom": "^15.5.4",
    "react-router-dom": "^4.1.1",
    "react-tag-input": "^4.7.1",
    "reactfire": "^1.0.0",
    "slugify": "^1.1.0"
  },

[BrunoQuaresma]

+1

[Kliton]

+1

[raunofreiberg]

Getting the same error here.

[Omortis]

Same here. Note that I'm not using PropTypes directly anywhere in my code though it seems to be called out many times by imported modules.

react@15.5.4
prop-types@15.5.10

Looks like it's mostly bootstrap 0.30 doing the dirty work?

[oshalygin]

Same issue, not using PropTypes from the react package anywhere in my code but its still throwing this warning.

EDIT: If anyone is still having my issue, make sure its not another package. A simple way is to pull up the dev tools and then look through the warning stacktrace by putting a breakpoint on the error and refreshing the page. Go up the callstack.

[nivek91]

+1

[JuliusPopoola]

+1

I have removed all references to PropTypes and the warning message is still showing

[steve-goodwin]

+1

[devjaw]

+1

[SH-Stark]

+1

[BHouwens]

+1

[tobiasandersen]

Seriously, please stop writing +1 comments. I'm sure the maintainers will fix this when they have the time and energy to do so. If you still feel like you have to +1, use the reaction feature provided by GitHub for that exact purpose.

Each time you write a new comment, a lot of people will get notifications about it (yes, I know that I'm doing the same here, sorry about that). And also, consider that the people maintaining this library is probably doing it on their free time, and that they might already be stressed/feel guilty about open issues and PRs (which they really shouldn't!).

[tawanorg]

+1

[javivelasco]

@tobiasandersen, your comment should be stated at the top of the README. You totally nailed it and indeed I'm working on this on my spare time. It is generating a lot of personal issues that I can't take anymore, and I feel like I can't deal with all. I can still work on the project but probably not as much as the community might require. This is open source, please contribute everybody and I promise I'll be checking on PRs and releasing new versions when I have time for it.

BTW, a new version was already released with support for React 15.5 so I'm closing.
Thank you

[kalm42]

+1

[gouzaa]

+1

[hongduclam]

+1

[javivelasco]

Such a pity you three can't be banned from using the project

[srajiv-xpio]

+1

[ghost]

+1

[zzwar2009]

+1

[jaydevonline]

And above three also.

[ghost]

+1

[ghost]

@tobiasandersen plus 1 add information about how recently ppl have been having the issue

[tobiasandersen]

@ericswenson15 What are you talking about? This issue is fixed in the latest release.

[javivelasco]

@ericswenson15 this is solved. If you are getting this warning with the latest react-toolbox it is some other lib

[thekhenzie]

+1

[rubenmoya]

Not sure about that last +1, but if you're having the same problem, please open a new issue, since this one was closed months ago, thank you! :)

[chenop]

I was getting this error for a whlie , until I figure out that the following line also produce this error:
import * as React from "react";
Fixing to the following in all my files:
import React from "react";
Did the trick for me.