Skip to content

Implement auto scroll into ScrollView (#60) #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 22, 2020
Merged

Implement auto scroll into ScrollView (#60) #118

merged 1 commit into from
Sep 22, 2020

Conversation

bedrich-schindler
Copy link
Contributor

No description provided.

@bedrich-schindler bedrich-schindler self-assigned this Jul 6, 2020
mbohal
mbohal requested changes Jul 7, 2020
View reviewed changes
adamkudrna
adamkudrna reviewed Jul 9, 2020
View reviewed changes
Copy link
Member

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we currently need only this behaviour but at least I'd consider opt-in autoscroll to the end when content is added and the viewport is scrolled somewhere in the middle, not at start, nor at the end. What do you think?

@adamkudrna adamkudrna added this to the v0.34.0 milestone Jul 20, 2020
@adamkudrna adamkudrna linked an issue Jul 20, 2020 that may be closed by this pull request
Create AutoScroll component #60
Closed
@bedrich-schindler
Copy link
Contributor Author

I know we currently need only this behaviour but at least I'd consider opt-in autoscroll to the end when content is added and the viewport is scrolled somewhere in the middle, not at start, nor at the end. What do you think?

I agree.

@bedrich-schindler bedrich-schindler force-pushed the feature/60 branch 3 times, most recently from b655d32 to 1f681c9 Compare September 10, 2020 13:04
@bedrich-schindler
Copy link
Contributor Author

@adamkudrna @mbohal It was re-worked and rebased due to amount of changes in master. A tested it in all modes (off, always, detectEnd) in Chrome, Firefox and Safari on MacOS and it worked in all cases. Hope it is finally done, I spent a lot of time on that.

adamkudrna
adamkudrna reviewed Sep 10, 2020
View reviewed changes
Copy link
Member

@adamkudrna adamkudrna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! I tested it in Chrome, FF, and on my iPad and it works.

mbohal
mbohal approved these changes Sep 19, 2020
View reviewed changes
@bedrich-schindler bedrich-schindler merged commit 313a20d into master Sep 22, 2020
@bedrich-schindler bedrich-schindler deleted the feature/60 branch September 22, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbohal mbohal mbohal approved these changes

@adamkudrna adamkudrna adamkudrna approved these changes

Assignees

@bedrich-schindler bedrich-schindler

Labels
feature
Projects
None yet
Milestone
v0.34.0
Development

Successfully merging this pull request may close these issues.

Create AutoScroll component
3 participants
@bedrich-schindler @mbohal @adamkudrna