Skip to content

Extend display utilities #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2020
Merged

Extend display utilities #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
916ad79
Simplify the ID attribute syntax in `ScrollView`
adamkudrna Sep 24, 2020
e863715
Add a couple of expected display utilities
adamkudrna Sep 24, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/lib/components/ui/ScrollView/ScrollView.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,13 +212,13 @@ export const ScrollView = (props) => {
customStartShadowStyle,
customEndShadowStyle,
)}
{...(id && { id })}
id={id}
>
<div className={styles.viewport} ref={scrollViewViewportEl}>
<div
className={styles.content}
ref={scrollViewContentEl}
{...(id && { id: `${id}__content` })}
id={id && `${id}__content`}
>
{children}
</div>
Expand All @@ -236,7 +236,7 @@ export const ScrollView = (props) => {
arrowsScrollStep,
)}
title={translations.previous}
{...(id && { id: `${id}__arrowPrevButton` })}
id={id && `${id}__arrowPrevButton`}
>
{customPrevArrow || (
<span className={styles.arrowIcon} aria-hidden />
Expand All @@ -252,7 +252,7 @@ export const ScrollView = (props) => {
arrowsScrollStep,
)}
title={translations.next}
{...(id && { id: `${id}__arrowNextButton` })}
id={id && `${id}__arrowNextButton`}
>
{customNextArrow || (
<span className={styles.arrowIcon} aria-hidden />
Expand Down
2 changes: 1 addition & 1 deletion src/lib/components/ui/Table/__tests__/Table.test.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,7 @@ describe('rendering', () => {
});

describe('functionality', () => {
it('calls changeHandler() on Close button click', () => {
it('calls changeHandler() on sorting button click', () => {
const spy = sinon.spy();
const component = mount((
<Table
Expand Down
4 changes: 2 additions & 2 deletions src/lib/styles/settings/_utilities.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ $utilities: (
responsive: true,
property: display,
class: d,
values: (block, flex, inline, inline-flex, none),
values: (block, flex, inline, inline-block, inline-flex, none),
),
'align-items': (
responsive: true,
Expand All @@ -19,7 +19,7 @@ $utilities: (
responsive: true,
property: justify-content,
class: justify-content,
values: (start, end, center, space-between),
values: (start, flex-start, end, flex-end, center, space-between),
),
'margin-top': (
responsive: true,
Expand Down