Refactor Radio, CheckboxField and Toggle and make them themeable (#20)
#238
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inciples (#20) Make `FormLayout` row gap adjustable via `--rui-form-layout-row-gap`.
mbohal
approved these changes
Feb 26, 2021
|
I've been trying to go through whole PR, but there are just too many changes in CSS code I have not able to check, otherwise I would have spent hours on that. But I ran it and it works fine as well,. |
bedrich-schindler
approved these changes
Mar 1, 2021
…m themeable (#20) Check form fields are now themeable the same way as box form fields. Custom input styling has been inspired by Bootstrap 5. Breaking changes in theming API: `--rui-form-field-filled-*` → `--rui-form-field-box-filled-*` `--rui-form-field-outline-*` → `--rui-form-field-box-outline-*` `--rui-form-field-input-*` → `--rui-form-field-box-input-*` `--rui-form-field-border-*` → `--rui-form-field-box-border-*` `--rui-form-field-placeholder-color` → `--rui-form-field-box-placeholder-color` `--rui-form-field-size-*` → `--rui-form-field-box-size-*` `--rui-form-field-caret-*` → `--rui-form-field-box-select-caret-*` `--rui-form-field-disabled-select-option-color` → `--rui-form-field-box-select-option-disabled-color` Changed theme values: `--rui-link-color`: `#007bff` (actual `--rui-color-note`) → `var(--rui-color-active)` (resolves to `--rui-color-note`) `--rui-link-hover-color`: `#0056b3` → `var(--rui-color-active-hover)` `--rui-form-field-warning-default-border-color`: `var(--rui-color-warning-darker)` → `var(--rui-color-warning-dark)` New theme values: `--rui-color-active-*` `--rui-color-on-active` `--rui-focus-box-shadow` `--rui-form-field-check-*` + related validation state properties, see the docs `--rui-form-layout-row-gap`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here it comes 🎊. What has changed? For these components, basically everything.
Toolbaror inFormLayout.FormLayout.Radio,CheckboxFieldandTogglehave been completely rewritten from the ground up to share the same visual principles and theming options with other form components. Default appearance has been made more generic and unopinionated.Before
After
Mind the help text wrapping — fields are now inline:
Help texts and validation texts make use of available space in context of
FormLayout:Getting back to the original appearance is possible:
New / Extended
Validation State Styling
Disabled State Styling
Closes #20.