Testing with react-testing-library #51
Conversation
src/components/Bar/Bar.spec.js
Outdated
| const { container, rerender } = render(<Bar size='sm' />) | ||
| const barEl = container.firstChild | ||
|
|
||
| expect(barEl).toHaveStyleRule('height', '27px') |
There was a problem hiding this comment.
wouldn't it be better if we compared rendered height to the helper variable that is used to specify Bar components height?
https://github.com/arturbien/React95/blob/ea317b8618e8fd064db8225c558cda9625cb40af/src/components/Bar/Bar.js#L4
https://github.com/arturbien/React95/blob/ea317b8618e8fd064db8225c558cda9625cb40af/src/components/Bar/Bar.js#L9
There was a problem hiding this comment.
Totally agree with u! Fixed :)
src/components/Button/Button.spec.js
Outdated
| expect(onButtonClick).toHaveBeenCalled() | ||
| }) | ||
|
|
||
| it('should render disabled', () => { |
There was a problem hiding this comment.
Here we should also test other variants of <Button /> . That's because variant="menu" and variant="flat" also have the disabled option. Below links to the Storybook where you can see both variants in disabled and not disabled state:
variant="menu"
variant="flat"
There was a problem hiding this comment.
cool, added more test cases for different variants :)
| expect(button).toHaveAttribute('type', 'submit') | ||
| }) | ||
|
|
||
| it('should handle click properly', () => { |
There was a problem hiding this comment.
We should also test if the button with disabled prop reacts to onClick (when button is disabled it doesn't trigger specified onClick prop when clicked).
There was a problem hiding this comment.
well-observed, thanks!
fixed :)
- Improve Bar tests with blockSizes from commom instead of static values - Test disabled Button callback function
|
🎉 This PR is included in version 3.0.0-beta.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Create an initial test structure using
jestand@testing-library/reactwith initial tests for the components:Obs: This is related to #27