Bad type definitions

[JimiPedros]

Property 'type' is missing in type '{ data: { labels: string[]; datasets: { label: string; data: number[]; fill: boolean; backgroundColor: string; borderColor: string; }[]; }; options: { scales: { yAxes: { ticks: { beginAtZero: boolean; }; }[]; }; }; }' but required in type 'Props'.

Following example and using a Line component in typescript codebase as such results in error above

<Line data={data} options={options} />

[eligundry]

I'm running into this too. I am on react-chartjs-2 v3.0.3 and chart.js v3.3.2. Looking at the Typescript definitions in this package at it's mainly powered by the following type import:

import Chart from 'chart.js/auto'

But looking at the types for v3 of chart.js, chart.js/auto does not seem to exist. Furthermore, they really refactored how they do types in v3.

[esemeniuc]

The type property gets overridden with type='line', so you can put anything for the value.

See:

react-chartjs-2/src/index.tsx

Line 12 in 67cd562

type='line'

[eligundry]

Completely understand that type gets discarded, but I'm also seeing issues across other props related to chart.js v3 getting rid of 'chart.js/auto'. For example the tick callbacks are impossible to type because it isn't importing the right type from chart.js.

[eligundry]

Nevermind, I think this was fixed and this issue might be closeable in the next release.

67cd562

[AshotN]

When is that next release happening?

[finnmerlett]

@YakovlevCoded FYI this is still not working for me. The fix is actually changing

import Chart from 'chart.js/auto';

to this

import * as Chart from 'chart.js/auto';

This is needed because the types referenced in this package as Chart.XXX are actually exported as interfaces directly from the chart.js/auto file, rather than as part of the Chart namespace.

[dangreen]

@JimiPedros @eligundry @finnmerlett Hi. Please checkout latest react-chartjs-2 version. Is this issue is still there?

[eligundry]

@dangreen This seems to have fixed it for me, thanks for the update!