Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade eslint & commander (out of current ranges) #525

Merged
merged 3 commits into from
Dec 14, 2019

Conversation

Throne3d
Copy link
Collaborator

The only scary changelog here is commander, which has jumped from v2 to v4 without a v3 and without much in the way of migration information.

However, since we only use it in lib/cli.js, and npm start -- --help and npm start -- --config=config.json both work after this change, it sure looks like we're fine to update this.

eslint is behaving fine – doesn't look like any of it affects us.

@Throne3d Throne3d added the dependencies Pull requests that update a dependency file label Dec 14, 2019
@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.126% when pulling 1836f19 on Throne3d:upgrade/deps-2019-12-14 into 33d12d7 on reactiflux:master.

@Throne3d Throne3d merged commit c5ad1a6 into reactiflux:master Dec 14, 2019
@Throne3d Throne3d deleted the upgrade/deps-2019-12-14 branch December 14, 2019 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants