Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed MiniCart popper occasionally being drawn at the wrong position. #336

Merged
merged 1 commit into from
Sep 25, 2018

Conversation

rosshadden
Copy link
Contributor

Resolves reactioncommerce/reaction-component-library#299
Impact: minor
Type: bugfix|style

Issue

Cart popper occasionally gets aligned too far right. It seems to fix itself after the first open, so seems to be related to on-load style differences like some other recent issues.

Solution

The empty cart's width was set to 320px, but the width of the populated cart is 360px. Because the cart is initially empty on-load, if you happen to open the MiniCart before it populates it will start at 320px and then resize to 360px, but keeping the same translate3d x value.

Making the empty cart be the same width as the populated cart fixed the issue.

Testing

  1. Add some items to your cart
  2. Refresh any page
  3. Try to open the MiniCart popper before the page finishes loading and before the cart has populated

@rosshadden rosshadden added the bug For issues that describe a defect or regression in the released software label Sep 25, 2018
@rosshadden rosshadden self-assigned this Sep 25, 2018
Copy link
Contributor

@nnnnat nnnnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nnnnat nnnnat merged commit 6948156 into develop Sep 25, 2018
@nnnnat nnnnat deleted the fix-299-minicart-render-issues branch September 25, 2018 19:05
This was referenced Jan 15, 2019
@spencern spencern mentioned this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug For issues that describe a defect or regression in the released software
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: MiniCart - Cart popper occasionally gets aligned too far right
2 participants