Fixed MiniCart popper occasionally being drawn at the wrong position. #336
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves reactioncommerce/reaction-component-library#299
Impact: minor
Type: bugfix|style
Issue
Cart popper occasionally gets aligned too far right. It seems to fix itself after the first open, so seems to be related to on-load style differences like some other recent issues.
Solution
The empty cart's width was set to
320px
, but the width of the populated cart is360px
. Because the cart is initially empty on-load, if you happen to open the MiniCart before it populates it will start at320px
and then resize to360px
, but keeping the sametranslate3d
x value.Making the empty cart be the same width as the populated cart fixed the issue.
Testing