chore: Set project license to Apache 2.0 #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machikoyasuda
suggested changes
Sep 26, 2018
There was a problem hiding this comment.
@spencern Looks good! Just to be sure, let's add it as a .md markdown file.
|
@machikoyasuda are you certain this should be a markdown file? The format does not appear to be markdown - I used the github license chooser to generate this file |
|
@spencern Ah! Then it should be alright. Once we merge this PR, the license should appear on the repo homepage, and that's how we'll know it's correct. |
machikoyasuda
approved these changes
Sep 26, 2018
|
Actually - one last thing - we should add a line about the Apache license down in the README here, https://github.com/reactioncommerce/reaction-next-starterkit#license |
|
👍 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #326
Impact: critical
Type: chore
Issue
We've needed to choose a license for this project.
Solution
@saralouhicks @ticean and I met to discuss this and while we're still working on a decision framework for choosing licenses for new projects, we'll use a permissive license, the Apache 2.0 license for this project.