Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(414): Fullname is not saved or displayed #420

Merged
merged 4 commits into from
Nov 8, 2018

Conversation

machikoyasuda
Copy link
Contributor

@machikoyasuda machikoyasuda commented Nov 7, 2018

Resolves #414
Impact: minor
Type: bugfix

Issue

  • Shipping address form is not saving fullName
  • Shipping address form is not displaying fullName

Solution

  • Submit fullName instead of firstName and lastName
  • Display fullName
  • Upgrades @reactioncommerce/components
  • Remove adaptAddressToFormFields function - No longer needed

Testing

  1. Fill out the form
  2. Look for the name to be displayed in both the form and the completed CheckoutAction

@machikoyasuda machikoyasuda added this to the Quandary milestone Nov 7, 2018
@machikoyasuda machikoyasuda changed the title fix(414): fix(414): Fullname is not saved or displayed Nov 7, 2018
Copy link
Contributor

@nnnnat nnnnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@nnnnat nnnnat merged commit e7ed95d into develop Nov 8, 2018
@nnnnat nnnnat deleted the 414-machikoyasuda-fullname branch November 8, 2018 15:56
This was referenced Jan 15, 2019
@spencern spencern mentioned this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shipping address full name is not autofilled when form is reloaded
2 participants