-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: 366 nnnnat address validation #421
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o children via props
nnnnat
changed the title
[WIP] feat: 366 nnnnat address validation
feat: 366 nnnnat address validation
Nov 19, 2018
machikoyasuda
approved these changes
Nov 19, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #366
Impact: major
Type: feature
Issue
#366
Solution
Created a
withAddressValidation
Query container that provides Checkout with theaddressValidation
GQL query method as well as any validation results returned from the validation service.Breaking changes
N/A
Testing
This PR requires Reaction 2.0.0-rc.7
Valid addresses
postal
code that starts with "9" (i.e.,90210
).Invalid addresses
postal
code that does not starts with "9" (i.e.,12345
).Edit an invalid address
postal
code that does not starts with "9" (i.e.,12345
).postal
code to start with a "9" and submit.Note: there is a small UI bug when you try to "Change" a set address, the InlineAlert will sometimes display empty, this is a bug within the component-lib and it being resolved in another PR