Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new order.referenceId as displayed order ID #434

Merged
merged 4 commits into from
Nov 26, 2018

Conversation

aldeed
Copy link
Contributor

@aldeed aldeed commented Nov 26, 2018

Impact: minor
Type: feature

Issue

There was no order ID that was provided by GraphQL that could be displayed to the customer and then also seen as a reference ID by the operator. There was a workaround for this in place, decoding the Order._id and showing that.

Solution

reactioncommerce/reaction#4827 introduces order.referenceId. This PR updates the storefront to display that ID on the order completion page.

Breaking changes

Tied to a change in Reaction API. Will not work with earlier versions of the API anymore.

Testing

See reactioncommerce/reaction#4827 testing instructions

Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mikemurray mikemurray merged commit cf9db10 into develop Nov 26, 2018
@mikemurray mikemurray deleted the feat-order-ref-id branch November 26, 2018 22:08
This was referenced Jan 15, 2019
@spencern spencern mentioned this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants