Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tlp title): add tag listing page's display title #450

Merged
merged 9 commits into from
Dec 12, 2018

Conversation

machikoyasuda
Copy link
Contributor

@machikoyasuda machikoyasuda commented Dec 5, 2018

Resolves #445
Impact: minor
Type: feature

Issue

  • Add the Display Title to the Tag Landing Page (called ProductGridPage)

Solution

  • Create ProductGridTitle component that takes a tag object and displays the tag object's displayTitle

screen shot 2018-12-05 at 3 31 19 pm

in code)

Breaking changes

None. If a tag doesn't have a displayTitle, the component will not render.

Testing

  1. Test a tag listing page with a title
  2. Test a tag listing page without a title
  3. Test with this PR feat(tag): add Display Title to Tag reaction#4856

Post-merge

Add Display Titles to some Tags in the Sample Catalog, for testing.

@machikoyasuda machikoyasuda changed the title [WIP] feat(tlp title): add tag listing page's display title feat(tlp title): add tag listing page's display title Dec 6, 2018
src/components/ProductGridTitle/ProductGridTitle.js Outdated Show resolved Hide resolved
src/components/ProductGridTitle/ProductGridTitle.js Outdated Show resolved Hide resolved
src/pages/tag.js Outdated Show resolved Hide resolved
@machikoyasuda
Copy link
Contributor Author

Ready for re-review @mikemurray

Copy link
Member

@mikemurray mikemurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mikemurray mikemurray merged commit 30845eb into develop Dec 12, 2018
@mikemurray mikemurray deleted the feat-445-tlp-title branch December 12, 2018 23:38
This was referenced Jan 15, 2019
@spencern spencern mentioned this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants