Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore : integrate ssr test + broken link checker to CI #473

Merged
merged 9 commits into from
Jan 7, 2019

Conversation

jeffcorpuz
Copy link
Contributor

@jeffcorpuz jeffcorpuz commented Jan 4, 2019

Resolves #456
Impact: minor
Type: test

Issue

  • SSR integration test was failing via CI, not locally.
  • Broken link checker was turned off due to flaky environments

Solution

Due to SSR need to be rendered on a browser, it needed a way to test it out.

A solution was to add the SSR / integration step as a dependency on the ecs-deploy job in CI with an accompanying staging url environment call. Similar to how future e2e tests will run.

To make sure it can be tested for local development, add a ternary conditional operation that defaults to localhost:4000 if no env variable is set.

Due to the stability of the staging environment, re-activate the broken link checker.

Runs as a dependency for the ecs-deploy job in CI.

Testing

  1. After successful merge to deploy, validate if tests run in CI
  2. Validate able to run locally without declaration of the URL variable and default runs via localhost on starter-kit

Example CI output : https://circleci.com/gh/reactioncommerce/reaction-next-starterkit/7376

@jeffcorpuz jeffcorpuz changed the title chore : integrate ssr test + broken link checker to ci chore : integrate ssr test + broken link checker to CI Jan 4, 2019
Copy link
Contributor

@griggheo griggheo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@aldeed aldeed merged commit dc8a5e5 into develop Jan 7, 2019
@aldeed aldeed deleted the chore-456-update-ssr-test branch January 7, 2019 23:22
This was referenced Jan 15, 2019
@spencern spencern mentioned this pull request Jan 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants