Skip to content
This repository has been archived by the owner on Dec 11, 2022. It is now read-only.

Add remaining identity provider flows #12

Merged
merged 10 commits into from
Dec 31, 2019
Merged

Add remaining identity provider flows #12

merged 10 commits into from
Dec 31, 2019

Conversation

aldeed
Copy link
Contributor

@aldeed aldeed commented Dec 30, 2019 •
edited
Loading

Resolves #2
Resolves reactioncommerce/example-storefront#357

Changes

  • Fix/finish the reset password flow
  • Implement the change password page / flow
  • Add an OAuth error page, which just displays errors from Hydra in a way that is consistent with the identity theme.
  • Updates the project to Meteor 1.8.3, and updates many NPM packages
  • Remove unused Meteor Accounts packages (login with Facebook, etc. is no longer supported)

Testing

Test this with reactioncommerce/example-storefront#637. All instructions are in that pull request.

@aldeed
feat: update to Meteor 1.8.3
58d6460 
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
@aldeed
feat: update to latest versions of most NPM pkgs
60bdfbc 
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
@aldeed
refactor: remove unused accounts packages
65fbbfc 
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
@aldeed
feat: finish implementing reset password flow
2c27d0d 
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
@aldeed
feat: implement change password flow
2317834 
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
@aldeed
feat: add OAuth error page
4670adf 
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
@aldeed
chore: lint fix
fd682b7 
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
@aldeed aldeed mentioned this pull request Dec 30, 2019
Merged
@aldeed aldeed requested a review from willopez December 30, 2019 20:13
@aldeed
fix: ensure logged out of Meteor after oauth login
bef0ad8 
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
@aldeed
feat: remove unused and less secure logout-user endpoint
1f95274 
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
@aldeed
chore: style fix
8dd5504 
Signed-off-by: Eric Dobbertin <eric@dairystatedesigns.com>
willopez
willopez approved these changes Dec 31, 2019
View reviewed changes
Copy link
Member

@willopez willopez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested along with corresponding PRs and looks good.

@willopez willopez merged commit 3c4ebb6 into trunk Dec 31, 2019
@rosshadden rosshadden mentioned this pull request Jan 9, 2020
Merged
@kieckhafer kieckhafer deleted the feat-aldeed-add-remaining-features branch January 23, 2020 20:39
@kieckhafer kieckhafer mentioned this pull request Feb 6, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Aug 25, 2021
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@willopez willopez willopez approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Finish forgot/change password flows Need OAuth error page
2 participants
@aldeed @willopez