Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: inconsistence in promotion schema #6686

Merged
merged 2 commits into from
Dec 5, 2022

Conversation

vanpho93
Copy link
Member

@vanpho93 vanpho93 commented Dec 5, 2022

Impact: minor
Type: bugfix

Issue

  • Incorrect discount value
  • Inconsistence on promotion schema

Solution

  • Update discount item calculation
  • Change field names

Testing

Added new unit test file:

  • packages/api-plugin-promotions-discounts/src/methods/index.test.js

@changeset-bot
Copy link

changeset-bot bot commented Dec 5, 2022

⚠️ No Changeset found

Latest commit: 1a2189b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vanpho93 vanpho93 merged commit 65ef2d6 into feat/promotions Dec 5, 2022
vanpho93 added a commit that referenced this pull request Apr 24, 2023
…romotion-schema

fix: inconsistence in promotion schema
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants