Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add price type for product #6696

Merged
merged 1 commit into from
Dec 14, 2022

Conversation

vanpho93
Copy link
Member

@vanpho93 vanpho93 commented Dec 9, 2022

Resolves #6638
Impact: major
Type: feature

Basically this is used to include or exclude items that are on sale or on clearance.

Stock price types are:

full - (not MSRP, but not discounted)
clearance - Permanently marked down to move
sale - Temporarily on sale (e.g. Black Friday or Mother's Day sale) but return to full price

@changeset-bot
Copy link

changeset-bot bot commented Dec 9, 2022

⚠️ No Changeset found

Latest commit: f33dd18

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Signed-off-by: vanpho93 <vanpho02@gmail.com>
@vanpho93 vanpho93 merged commit 6671d5b into feat/promotions Dec 14, 2022
@brent-hoover brent-hoover deleted the feat/add-price-type-for-product branch December 15, 2022 05:26
vanpho93 added a commit that referenced this pull request Apr 24, 2023
…r-product

feat: add price type for product
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants