Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: change start/end dates to DateTime rather than Date #6761

Merged
merged 6 commits into from
Jan 26, 2023
Merged

fix: change start/end dates to DateTime rather than Date #6761

merged 6 commits into from
Jan 26, 2023

Conversation

brent-hoover
Copy link
Collaborator

Promotion Dates should have always been DateTime so users can set a promo to start at a particular time.

@brent-hoover
fix: change start/end dates to DateTime rather than Date
163e39d 
Signed-off-by: Brent Hoover <brent@thebuddhalodge.com>
@brent-hoover brent-hoover mentioned this pull request Jan 13, 2023
Merged
@vanpho93
Copy link
Member

image

There are some failed tests related to this change.

@changeset-bot
Copy link

changeset-bot bot commented Jan 18, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 56904e1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Brent Hoover and others added 4 commits January 18, 2023 16:50
@brent-hoover
fix: use DateTime rather than Date for tests
4b34ead 
Signed-off-by: Brent Hoover <brent@thebuddhalodge.com>

Signed-off-by: Brent Hoover <brent@thebuddhalodge.com>
@brent-hoover
fix: make it a string for GraphQL
b9e65a5 
Signed-off-by: Brent Hoover <brent@thebuddhalodge.com>

Signed-off-by: Brent Hoover <brent@thebuddhalodge.com>
@brent-hoover
fix: use UTC for graphQL tests
6759eb8 
Signed-off-by: Brent Hoover <brent@thebuddhalodge.com>

Signed-off-by: Brent Hoover <brent@thebuddhalodge.com>
@brent-hoover
fix: use ISO for graphQL tests
56904e1 
Signed-off-by: Brent Hoover <brent@thebuddhalodge.com>

Signed-off-by: Brent Hoover <brent@thebuddhalodge.com>
@brent-hoover brent-hoover merged commit 84fe265 into feat/promotions Jan 26, 2023
@brent-hoover brent-hoover deleted the fix/use-date-time-for-promo-dates branch January 26, 2023 15:28
vanpho93 pushed a commit that referenced this pull request Apr 24, 2023
@brent-hoover @vanpho93
Merge pull request #6761 from reactioncommerce/fix/use-date-time-for-…
a9e4ca0 
…promo-dates

fix: change start/end dates to DateTime rather than Date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sujithvn sujithvn sujithvn approved these changes

@vanpho93 vanpho93 Awaiting requested review from vanpho93

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brent-hoover @vanpho93 @sujithvn