Skip to content

Docs revision #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Jul 3, 2022
Merged

Docs revision #85

merged 9 commits into from
Jul 3, 2022

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Jul 2, 2022 •
edited
Loading

This PR will require changing the required test names in the GitHub project settings.

Changelog

  • Use snake_case for component names
  • Add a page specific to settings.py configuration values
  • Change light/dark mode toggle button styling
  • Add docs tests
  • Rename functional tests

@Archmonger Archmonger marked this pull request as ready for review July 2, 2022 12:23
@Archmonger Archmonger requested a review from rmorshea July 3, 2022 03:01
@rmorshea rmorshea merged commit 9f0fa65 into reactive-python:main Jul 3, 2022
@rmorshea
Copy link
Contributor

rmorshea commented Jul 3, 2022

Sorry. I was on auto-pilot here and merged. Let me know if you'd like me to revert.

@Archmonger
Copy link
Contributor Author

Not a problem, all good.

@Archmonger Archmonger deleted the snake-case-and-more branch July 3, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmorshea rmorshea Awaiting requested review from rmorshea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Archmonger @rmorshea