Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read IDOM_DEBUG_MODE during runtime instead of initialization #582

Closed
Archmonger opened this issue Jan 12, 2022 · 0 comments · Fixed by #843
Closed

Read IDOM_DEBUG_MODE during runtime instead of initialization #582

Archmonger opened this issue Jan 12, 2022 · 0 comments · Fixed by #843
Labels
priority-2-moderate Should be resolved on a reasonable timeline. type-revision About a change in functionality or behavior
Milestone
1.0.0

Comments

@Archmonger
Copy link
Contributor

Archmonger commented Jan 12, 2022 •
edited
Loading

Current Situation

Currently, the value of IDOM_DEBUG_MODE is read only at first import of IDOM.

Proposed Actions

Read IDOM_DEBUG_MODE during runtime.

Work Items

Modify all locations utilizing IDOM_DEBUG_MODE to read it during runtime instead of only once during initialization.
@rmorshea rmorshea added this to the 1.0 milestone Jan 12, 2022
@rmorshea rmorshea added the type-feature About new capabilities label Jan 12, 2022
@Archmonger Archmonger changed the title Read IDOM_DEBUG_MODE during execution Read IDOM_DEBUG_MODE during runtime instead of initialization Jan 13, 2022
@rmorshea rmorshea added type-revision About a change in functionality or behavior priority-2-moderate Should be resolved on a reasonable timeline. and removed type-feature About new capabilities labels Jan 13, 2022
@Archmonger Archmonger mentioned this issue Jan 31, 2022
Closed
@Archmonger Archmonger mentioned this issue Feb 19, 2022
Closed
1 task
@rmorshea rmorshea mentioned this issue Nov 30, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-2-moderate Should be resolved on a reasonable timeline. type-revision About a change in functionality or behavior
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

Make IDOM_DEBUG_MODE mutable + add Option.subscribe method reactive-python/reactpy
2 participants
@rmorshea @Archmonger