Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Client Always Looks for Server at "/" #611

Closed
rmorshea opened this issue Jan 24, 2022 · 0 comments · Fixed by #612
Closed

Client Always Looks for Server at "/" #611

rmorshea opened this issue Jan 24, 2022 · 0 comments · Fixed by #612
Labels
priority-1-high Should be resolved ASAP. type-bug About something that isn't working
Milestone
1.0.0

Comments

@rmorshea
Copy link
Collaborator

Current Situation

Right now the expected location of the server is hard coded to be /. This should be changed to look at ../ relative to the current page.

Proposed Actions

Change this line to use document.location.pathname somehow: https://github.com/idom-team/idom/blob/main/src/client/packages/idom-app-react/src/index.js#L7

Work Items

Same as above.
@rmorshea rmorshea added type-bug About something that isn't working priority-1-high Should be resolved ASAP. labels Jan 24, 2022
@rmorshea rmorshea added this to the 1.0 milestone Jan 24, 2022
@rmorshea rmorshea mentioned this issue Jan 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
priority-1-high Should be resolved ASAP. type-bug About something that isn't working
Projects
None yet
Milestone
1.0.0
Development

Successfully merging a pull request may close this issue.

make connection to websocket relative path reactive-python/reactpy
1 participant
@rmorshea