Skip to content

Add <marquee> element #1164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

Minejerik
Copy link

@Minejerik Minejerik commented Nov 20, 2023

This commit simply adds the option to use the marquee element in reactpy. While yes, the marquee element has been deprecated, I think that it would be best to allow web developers the freedom to use this element even when it is deprecated. Also the marquee element is still usable in all major browsers.

By submitting this pull request you agree that all contributions to this project are made under the MIT license.

Issues

The issue was that I was unable to use the marquee element in a project I was working on.

Solution

I simply added the marquee element in html.py

Checklist

  • Tests have been included for all bug fixes or added functionality.
  • The changelog.rst has been updated with any significant changes.

This commit simply adds the option to use the marquee element in reactpy. While yes, the marquee element has been deprecated, I think that it would be best to allow web developers the freedom to use this element even when it is deprecated. Also the marquee element is still usable in all major browsers.
@rmorshea
Copy link
Collaborator

rmorshea commented Nov 20, 2023

Looks like <marquee> is deprecated according to Mozilla. Given that, it doesn't seem like we should add this to ReactPy. If needed, you can always create this using reactpy.vdom("marquee", ...). Thanks for the contribution though!

@rmorshea rmorshea closed this Nov 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants