Skip to content

Conversation

rmorshea
Copy link
Collaborator

Closes: #480, #451

The client-side model was being mutated on each update
in order to try and be more performant. This is a problem
though because React relies on checking the identity of
some parts of the model to see if things have changed.

No we create a copy of the model each time it changed
@rmorshea rmorshea merged commit 0aa7a66 into main Aug 27, 2021
@rmorshea rmorshea deleted the fix-480 branch August 27, 2021 08:48
@rmorshea rmorshea mentioned this pull request Aug 27, 2021
2 tasks
@rmorshea rmorshea changed the title Fix 480 Do not mutate client-side model Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Style Cannot Be Updated
1 participant