Skip to content

Clean up WS console logging #522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 27, 2021
Merged

Clean up WS console logging #522

merged 1 commit into from
Oct 27, 2021

Conversation

Archmonger
Copy link
Contributor

@Archmonger Archmonger commented Oct 27, 2021 •
edited
Loading

  • Changes WS console.log() -> console.info()
  • Verbosely state that the console printouts are coming from IDOM

rmorshea
rmorshea approved these changes Oct 27, 2021
View reviewed changes
Copy link
Collaborator

@rmorshea rmorshea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@rmorshea rmorshea merged commit 65202ff into reactive-python:main Oct 27, 2021
@Archmonger Archmonger deleted the reduce-console-log branch October 27, 2021 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rmorshea rmorshea rmorshea approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Archmonger @rmorshea