fix bug in element key identity #563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmorshea
force-pushed
the
fix-556
branch
4 times, most recently
from
48dcdd1
to
b53d9cd
Compare
old children by key were being copied for elements. as a result we were attempting to delete elements more than once.
as a result of this additional check, we found what seemed to be an unnecessary assertion about old component state havint the same key and index. we change the assertion to only check for the same key since only the key is meaningful for identity
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #556
Includes a fix for stefankoegl/python-json-patch#138 in
jsonpatchAdditionally, we were copying the
children_by_keydictionary when updating elements.