Fix idom.run and more renaming of server to backend #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
@rmorshea Should we add a task to v2 to have functional tests for |
|
It actually looks like there is a test. Not sure why it didn't catch it. |
|
I wasn't able to locate the test in the repo. But perhaps it's not checking running via the default (unspecified) server implementation? |
|
Ah, yup. That's exactly it. |
|
The trouble is that we have to specify the implementation as Flask because the others don't play nice in threads. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Renames
idom.servertoidom.backendalso renamedServerFixturetoBackendFixture+DisplayFixture.servertoDisplayFixture.backend.Checklist:
Please update this checklist as you complete each item:
changelog.rsthas been updated with any significant changes.