Skip to content

add asgiref dep + set default timeout on page #776

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 1, 2022
Merged

add asgiref dep + set default timeout on page #776

merged 4 commits into from
Jul 1, 2022

Conversation

rmorshea
Copy link
Collaborator

@rmorshea rmorshea commented Jun 26, 2022 •
edited
Loading

Description

  • Add asgiref as a dependency (must have been included by another package before now).
  • Set default timeout on playwright page for testing - we have a IDOM_TESTING_DEFAULT_TIMEOUT, but it's not applied there.

Checklist:

Please update this checklist as you complete each item:

  • Tests have been included for all bug fixes or added functionality.
  • The changelog.rst has been updated with any significant changes.
  • GitHub Issues which may be closed by this Pull Request have been linked.
  • I have left irrelevant checklist items unchecked instead of removing them.

@rmorshea rmorshea merged commit 4500d55 into main Jul 1, 2022
@rmorshea rmorshea deleted the add-asgiref-dep branch July 1, 2022 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rmorshea