remove should_render #870
Merged
remove should_render #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmorshea
force-pushed
the
remove-should-render
branch
2 times, most recently
from
4015997
to
0736668
Compare
also adds a regression test in the case a component does not render its children
rmorshea
force-pushed
the
remove-should-render
branch
from
0736668
to
2590f17
Compare
rmorshea
commented
Jan 8, 2023
|
I'm actually ok merging this without review. |
Archmonger
reviewed
Jan 9, 2023
|
|
||
| **Fixed** | ||
|
|
||
| - :issue:`846` - Nested context does no update value if outer context should not render. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #846, #847
Checklist
Please update this checklist as you complete each item:
changelog.rsthas been updated with any significant changes.