[Bug]: ReactiveUI.Testing NuGet package does not contain some TFMs

[Cheesebaron]

Describe the bug 🐞

Looks like the new ReactiveUI.Testing packages do not contain net6.0+ TFMs only net462, net472, net8.0-windows, net9.0-windows and net10.0-windows. Screenshot from NuGet.org:

So now when I restore packages on my xUnit Unit Test project I get the following warning:

Restore succeeded with 1 warning(s) in 5.8s
    /Users/tomaszcielecki/git/DrivingRangeApp/Tests/UnitTests/UnitTests.csproj : warning NU1701: Package 'ReactiveUI.Testing 22.0.1' was restored using '.NETFramework,Version=v4.6.1, .NETFramework,Version=v4.6.2, .NETFramework,Version=v4.7, .NETFramework,Version=v4.7.1, .NETFramework,Version=v4.7.2, .NETFramework,Version=v4.8, .NETFramework,Version=v4.8.1' instead of the project target framework 'net9.0'. This package may not be fully compatible with your project.

Step to reproduce

1. Add reference to ReactiveUI.Testing version 22.0.1 in a Unit Test library targeting net9.0
2. Restore packages

Expected behavior

I would have expected plain net8.0, net9.0 targets in the package too and not generate a warning when restoring packages on my Unit Test project.

Screenshots 🖼️

No response

IDE

No response

Operating system

No response

Version

No response

Device

No response

ReactiveUI Version

22.0.1

Additional information ℹ️

No response

[glennawatson]

net461 support was dropped by Microsoft a while back

https://devblogs.microsoft.com/dotnet/net-framework-4-5-2-4-6-4-6-1-will-reach-end-of-support-on-april-26-2022/

We don't support out of date TFMs

.NET Blog

.NET Framework 4.5.2, 4.6, 4.6.1 will reach End of Support on April 26, 2022 - .NET Blog

.NET Framework 4.5.2, 4.6, 4.6.1 will reach End of Support on April 26, 2022. Update your deployed framework runtime to a supported version.

[glennawatson]

Same scenario with net6

[glennawatson]

https://dotnet.microsoft.com/en-us/platform/support/policy

Microsoft

The official .NET support policy | .NET

Learn about support policies, and the various ways to get support, for the .NET platform. Includes support information for ASP.NET, Entity Framework, .NET MAUI, and more.

[Cheesebaron]

@glennawatson I think you misread. What I am saying is that it only contains net452 and net472 but it does not contain newer TFMs like net9.0 only -windows variants. Can we reopen this?

[Cheesebaron]

22.0.1 contains:

Older 19.6.12:

I would love for net8.0+ to be included

[glennawatson]

Ah thanks for clarifying, yeah makes sense I'll re-open

[Cheesebaron]

Looking through the code it uses:

ReactiveUI/src/ReactiveUI.Testing/ReactiveUI.Testing.csproj

Line 3 in 1ed95b6

<TargetFrameworks>$(ReactiveUIFinalModernTargetFrameworks)</TargetFrameworks>

Which maps to:

ReactiveUI/src/Directory.Build.props

Line 68 in 1ed95b6

<ReactiveUIModernTargets>net8.0;net9.0;net10.0</ReactiveUIModernTargets>

However, when building on Windows it does:

ReactiveUI/src/Directory.Build.props

Line 84 in 1ed95b6

<ReactiveUIFinalModernTargetFrameworks Condition="$([MSBuild]::IsOsPlatform('Windows'))">$(ReactiveUIFrameworkTargets);$(ReactiveUIWindowsTargets)</ReactiveUIFinalModernTargetFrameworks>

Which picks up:

ReactiveUI/src/Directory.Build.props

Line 47 in 1ed95b6

<ReactiveUIFrameworkTargets Condition="$([MSBuild]::IsOsPlatform('Windows'))">net462;net472</ReactiveUIFrameworkTargets>

Would you mind me making a PR to fix this? Do you intend to still keep net462 and net472?

If you want to keep them, I can just make sure the original value of ReactiveUIFinalModernTargetFrameworks gets used in addition to the windows targets

[glennawatson]

net462/net472 are still supported so we'll keep support while they are.

likely it'll just need the -windows platforms for the drawing/wpf/uwp/winui type platforms, and for rxui will just need net8/9/10. net462/472 would still be there similar to net8/9/10 though for rxui package.

so just shuffling around the properties in the directory.build.props files

go ahead and provide a PR

[Cheesebaron]

I will give it a go. Thanks!