New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The container id generation causes problems icw caching #230

Closed
Jonne opened this Issue Feb 20, 2016 · 4 comments

Comments

Projects
None yet
3 participants
@Jonne
Copy link

Jonne commented Feb 20, 2016

Of some components we cache the HTML output on the server. However, the current container id generation is based on identity. This results in duplicate ids in the HTML, causing components to be instantiated in the wrong divs. We solved this by using a non-deterministic algorithm:

System.Convert.ToBase64String(Guid.NewGuid().ToByteArray()).TrimEnd('=');

@Daniel15

This comment has been minimized.

Copy link
Member

Daniel15 commented Feb 23, 2016

Good catch, thanks!

@Daniel15 Daniel15 self-assigned this Feb 23, 2016

@Daniel15 Daniel15 closed this in 68ecda2 Mar 6, 2016

@thebuilder

This comment has been minimized.

Copy link

thebuilder commented Mar 14, 2016

Any ETA of when the next version will be released to Nuget with this fix? We just ran into when enabled caching on our site.

Thanks! 😃

@Daniel15

This comment has been minimized.

Copy link
Member

Daniel15 commented Apr 12, 2016

Sorry, didn't see your comment. I've got a few updates, so I'll push a new build tonight.

@Daniel15

This comment has been minimized.

Copy link
Member

Daniel15 commented Apr 17, 2016

ReactJS.NET 2.3 (including this fix) was pushed on 11th April

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment