The container id generation causes problems icw caching #230

Closed
Jonne opened this Issue Feb 20, 2016 · 4 comments

Projects

None yet

3 participants

@Jonne
Jonne commented Feb 20, 2016

Of some components we cache the HTML output on the server. However, the current container id generation is based on identity. This results in duplicate ids in the HTML, causing components to be instantiated in the wrong divs. We solved this by using a non-deterministic algorithm:

System.Convert.ToBase64String(Guid.NewGuid().ToByteArray()).TrimEnd('=');

@Daniel15
Member

Good catch, thanks!

@Daniel15 Daniel15 self-assigned this Feb 23, 2016
@Daniel15 Daniel15 closed this in 68ecda2 Mar 6, 2016
@thebuilder

Any ETA of when the next version will be released to Nuget with this fix? We just ran into when enabled caching on our site.

Thanks! 😃

@Daniel15
Member

Sorry, didn't see your comment. I've got a few updates, so I'll push a new build tonight.

@Daniel15
Member
Daniel15 commented Apr 17, 2016 edited

ReactJS.NET 2.3 (including this fix) was pushed on 11th April

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment