New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to disable[.NET] warnings? #316

Closed
vladop opened this Issue Sep 15, 2016 · 1 comment

Comments

Projects
None yet
2 participants
@vladop

vladop commented Sep 15, 2016

I tryied setting NODE_ENV=production on my Windows server. I was really really exited about this project but today little bit dissapointed with performance in production. I think it will help with performance on server side if I disable some checks in code which result in warnings, but it seems setting NODE_ENV does not take effect,

@Daniel15

This comment has been minimized.

Member

Daniel15 commented Sep 15, 2016

Wow, good catch! Looks like I forgot about this and there's still a todo in the code 😒

https://github.com/reactjs/React.NET/blob/master/src/React.Core/JavaScriptEngineFactory.cs#L109-L110

You can try building your own build of ReactJS.NET if you like. Clone this repo, modify that line of code to load react.generated.min.js rather than react.generated.js, then run dev-build.bat to build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment