How to disable[.NET] warnings? #316

Closed
imperat0r opened this Issue Sep 15, 2016 · 1 comment

Projects

None yet

2 participants

@imperat0r

I tryied setting NODE_ENV=production on my Windows server. I was really really exited about this project but today little bit dissapointed with performance in production. I think it will help with performance on server side if I disable some checks in code which result in warnings, but it seems setting NODE_ENV does not take effect,

@Daniel15
Member

Wow, good catch! Looks like I forgot about this and there's still a todo in the code 😒

https://github.com/reactjs/React.NET/blob/master/src/React.Core/JavaScriptEngineFactory.cs#L109-L110

You can try building your own build of ReactJS.NET if you like. Clone this repo, modify that line of code to load react.generated.min.js rather than react.generated.js, then run dev-build.bat to build.

@Daniel15 Daniel15 added a commit that closed this issue Oct 3, 2016
@Daniel15 Daniel15 Add option to use production version of React. Closes #316 3ea6f8b
@Daniel15 Daniel15 closed this in 3ea6f8b Oct 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment