New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please move the middleware-related classes into a separate nuget package #388

Closed
dima117 opened this Issue Mar 26, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@dima117

dima117 commented Mar 26, 2017

Hi
I need to use the react middleware in the console application to convert JSX files on-the-fly. But I do not need to use ASP.NET MVC (and I hurt because ASP.NET MVC packages are in the dependency list of my project). Could you move the middleware-related classes into a separate nuget package?

@Daniel15

This comment has been minimized.

Member

Daniel15 commented Apr 3, 2017

Interesting idea. I could move the MVC classes into a new React.AspNet.Mvc package, and change React.AspNet to just contain the middleware. What do you think?

@Daniel15 Daniel15 added the Enhancement label Apr 3, 2017

@dima117

This comment has been minimized.

dima117 commented Apr 3, 2017

Yes, it sounds reasonable. Also should keeping in mind that this will be a breaking change for the current users of the React.AspNet package.

@Daniel15

This comment has been minimized.

Member

Daniel15 commented Jul 2, 2017

This is included in the 3.1 release: https://reactjs.net/2017/07/3.1.0-release.html. You can now install React.AspNet.Middleware to just get the middleware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment