Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose MaxUsagesPerEngine as an configuration option in React.NET #416

Merged
merged 3 commits into from Jul 2, 2017
Merged

Expose MaxUsagesPerEngine as an configuration option in React.NET #416

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f512b06
Expose MaxUsagesPerEngine as an configuration option in React.NET
Halstatt Jun 12, 2017
a54470a
Added forwarding of stack traces from React.NET console mock
Halstatt Jun 26, 2017
80839fa
Merge branch 'master' into master
Daniel15 Jul 2, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
11 changes: 11 additions & 0 deletions src/React.Core/IReactSiteConfiguration.cs
View file
Open in desktop
Expand Up @@ -102,6 +102,17 @@ public interface IReactSiteConfiguration
/// </summary>
IReactSiteConfiguration SetMaxEngines(int? maxEngines);

/// <summary>
/// Gets or sets the maximum number of times an engine can be reused before it is disposed.
/// <c>0</c> is unlimited. Defaults to <c>100</c>.
/// </summary>
int? MaxUsagesPerEngine { get; set; }
/// <summary>
/// Sets the maximum number of times an engine can be reused before it is disposed.
/// <c>0</c> is unlimited. Defaults to <c>100</c>.
/// </summary>
IReactSiteConfiguration SetMaxUsagesPerEngine(int? maxUsagesPerEngine);

/// <summary>
/// Gets or sets whether the MSIE engine should be used if V8 is unavailable.
/// </summary>
Expand Down
4 changes: 4 additions & 0 deletions src/React.Core/JavaScriptEngineFactory.cs
View file
Open in desktop
Expand Up @@ -100,6 +100,10 @@ protected virtual IJsPool CreatePool()
{
poolConfig.StartEngines = _config.StartEngines.Value;
}
if (_config.MaxUsagesPerEngine != null)
{
poolConfig.MaxUsagesPerEngine = _config.MaxUsagesPerEngine.Value;
}

var pool = new JsPool(poolConfig);
// Reset the recycle exception on recycle. If there *are* errors loading the scripts
Expand Down
15 changes: 15 additions & 0 deletions src/React.Core/ReactSiteConfiguration.cs
View file
Open in desktop
Expand Up @@ -191,6 +191,21 @@ public IReactSiteConfiguration SetMaxEngines(int? maxEngines)
return this;
}

/// <summary>
/// Gets or sets the maximum number of times an engine can be reused before it is disposed.
/// <c>0</c> is unlimited. Defaults to <c>100</c>.
/// </summary>
public int? MaxUsagesPerEngine { get; set; }
/// <summary>
/// Sets the maximum number of times an engine can be reused before it is disposed.
/// <c>0</c> is unlimited. Defaults to <c>100</c>.
/// </summary>
public IReactSiteConfiguration SetMaxUsagesPerEngine(int? maxUsagesPerEngine)
{
MaxUsagesPerEngine = maxUsagesPerEngine;
return this;
}

/// <summary>
/// Gets or sets whether the MSIE engine should be used if V8 is unavailable.
/// </summary>
Expand Down