New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to JSPool 3.0 #421

Merged
merged 3 commits into from Jul 2, 2017

Conversation

Projects
None yet
1 participant
@Daniel15
Member

Daniel15 commented Jul 2, 2017

Upgrades ReactJS.NET to use JSPool 3.0, and updates all JavaScriptEngineSwitcher dependencies to their latest versions

Also adds an assembly redirect hack for MSBuild so that it can correctly load JavaScriptEngineSwitcher.Core when JavaScriptEngineSwitcher.V8 references an older version. Normally this would be done in Web.config or app.config as an assembly redirect, but that does not work in MSBuild. The only way to do it in MSBuild is to manually redirect the assembly.

Daniel15 added some commits Jul 2, 2017

@Daniel15 Daniel15 added this to the 3.1 milestone Jul 2, 2017

@Daniel15 Daniel15 self-assigned this Jul 2, 2017

{
// This could be called from ReactEnvironment.Dispose if that class is disposed after
// this class. Let's just ignore this if it's disposed.
if (!_disposed)
{
_pool.ReturnEngineToPool(engine);
engine.Dispose();

This comment has been minimized.

@Daniel15

Daniel15 Jul 2, 2017

Member

This is probably not needed... The call site could just call Dispose on the engine directly.

@Daniel15 Daniel15 merged commit e6ce44a into master Jul 2, 2017

2 checks passed

continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details

@Daniel15 Daniel15 deleted the jspool3 branch Jul 2, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment