New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude node_modules #442

Merged
merged 1 commit into from Oct 19, 2017

Conversation

Projects
None yet
3 participants
@dustinsoftware
Collaborator

dustinsoftware commented Oct 11, 2017

This fixes building within VS 2017 community.
node_modules can sometimes contain paths that are very long, which can
trigger an msbuild bug

Microsoft/msbuild#406

Exclude node_modules
This fixes building within VS 2017 community.
node_modules can sometimes contain paths that are very long, which can
trigger an msbuild bug

Microsoft/msbuild#406
@dustinsoftware

This comment has been minimized.

Collaborator

dustinsoftware commented Oct 12, 2017

No appveyor build? cc @Daniel15

@Daniel15

This comment has been minimized.

Member

Daniel15 commented Oct 12, 2017

huh, I have no idea why Appveyor didn't build this. I'll try to look into that soon.

@Daniel15

This comment has been minimized.

Member

Daniel15 commented Oct 16, 2017

Strangely, the webhook to AppVeyor threw an error saying that the PR doesn't exist:

I re-ran the webhook, which should kick off the AppVeyor build. Looks like it's currently queued.

@Daniel15

This comment has been minimized.

Member

Daniel15 commented Oct 19, 2017

The AppVeyor build never completed, but I feel pretty safe about this change. Let's merge it and see what happens 😛

@Daniel15 Daniel15 merged commit 36c653f into reactjs:master Oct 19, 2017

1 check was pending

continuous-integration/appveyor/pr Waiting for AppVeyor build to complete
Details
@defcon84

This comment has been minimized.

defcon84 commented Oct 19, 2017

Livin' on the edge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment